1617678 - Backplate-HCM should only expose background images from URLs

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Morgan Reschenberg [:morgan]]

HCM users have reported (web compat?) issues with sites that use linear gradients or solid-colour images as backgrounds on various HTML elements. With backplate landed, these elements are now exposed to users in HCM.

It would be good to sorta remove these by only allowing URL-based background images. Hopefully this will help our users who rely on HCM to simulate not only contrast, but dark (or colour-controlled) mode.

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1617678: Modify background image styling to only apply URL-sourced images when backplate is enabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3ad7ffa787
Modify background image styling to only apply URL-sourced images when backplate is enabled. r=emilio

Comment 3

[Razvan Maries]

Backed out for perma failures on bg-image-div-001.html.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=dc3ad7ffa7870a9f0688dee3e79dac7284ac4fe5&selectedJob=291491888&searchStr=Android%2C7.0%2Cx86-64%2Cdebug%2CReftests%2Ctest-android-em-7.0-x86_64%2Fdebug-geckoview-reftest-e10s-2%2CR%28R2%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291491888&repo=autoland&lineNumber=7022

Backout: https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=e8c3497dcac1ef7e8b8de5a3f97457b06b55aea8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d37d37982c08
Modify background image styling to only apply URL-sourced images when backplate is enabled. r=emilio

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d37d37982c08