1617751 - Assertion failure calling gl->Screen()->Front()->ToSurfaceDescriptor() in WebGLContext::Present (on Android)

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Imanol Fernandez]

Crash report from Firefox Reality: https://crash-stats.mozilla.com/report/index/8237e8f0-e8d8-4071-a28f-d7ff40200220

Comment 1

[Imanol Fernandez]

The crash only happens with e10s disabled. After some research I was able to reproduce the issue using a minimal testcase:

• If a canvas is sized using CSS styles the webgl test runs correctly
• If a canvas is sized using JS (canvas.width = value) gl->Screen()->Front()->ToSurfaceDescriptor() crashes

The problem is related to backbuffer not being regenerated after the gl->Screen()->Morph(std::move(factory)) call. When using JS sized canvas the DrawingBufferSize and gl->Screen()->Size() are equal. This leads to Resize not being called in PresentScreenBuffer, which ends with a FrontBuffer which has not been created using the new factory after screen->PublishFrame();

Comment 2

[Kelsey Gilbert [:jgilbert]]

Yep, that sounds like a problem.

Comment 3

[Kelsey Gilbert [:jgilbert]]

What I'm thinking of doing is changing this API generally to be BlitToNewSharedSurface, instead of the current GLScreenBuffer dance.

Comment 4

[Imanol Fernandez]

Attachment: Bug 1617751 - Ensure that GLScreenBuffer back buffer is created using the newly attached factory.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3a8032a4a14
Ensure that GLScreenBuffer back buffer is created using the newly attached factory r=jgilbert

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/e3a8032a4a14

Comment 7

[Razvan Maries]

Backed out for andoird webgl failures.

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290802300&repo=autoland&lineNumber=1953

Backout: https://hg.mozilla.org/integration/autoland/rev/2e06f187b37127a9640b077da662bf878cb82acd

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/2e06f187b371

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d3e96a5a07a
Ensure that GLScreenBuffer back buffer is created using the newly attached factory. r=jgilbert

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8d3e96a5a07a