1617769 - Pass bindgen clang args ourselves rather than rely on individual crates doing they homework

Status: RESOLVED WONTFIX

(Firefox Build System :: General, task)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1617769 - Pass bindgen clang args ourselves. r=#build!

Bingen supports a BINDGEN_EXTRA_CLANG_ARGS environment variable since
version 0.49.0. Use that instead of relying on individual crates doing
it properly (hint: some crates in Firefox don't do it at all, breaking
some cross-compilation setups).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1617769 - Remove the now unused AC_SUBST_TOML_LIST macro. r=#build!

Depends on D63991

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1617769 - Don't read the now empty extra bindgen flags file from the baldrdash crate. r=#build!

The build system now does due diligence on its own.

Depends on D63992

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1617769 - Don't read the now empty bindgen config from the style crate. r=#build!

The build system now does due diligence on its own.

Depends on D63993

Comment 5

[Mike Hommey [:glandium]]

After these 4 patches, we're left with neqo, which is vendored and will have to be dealt with separately.

Comment 6

[Mike Hommey [:glandium]]

https://github.com/mozilla/neqo/pull/471

Comment 7

[Mike Hommey [:glandium]]

For now, I'm going to bail on this. This is a massive can of worms.

• Some bindgen callers are not actually generating bindings for C++, but we unconditionally pass flags for C++
• Many callers don't actually need many of the Gecko-specific flags that are set via basic_bindgen_cflags. Those flags have been originally set for servo, and have essentially been cargo culted most of everywhere.
• Some bindgen callers need the same C/C++ standard flags as Gecko, some don't.

It somehow works out ok right now but is a big mess, and a single BINDGEN_EXTRA_CLANG_ARGS across the tree doesn't help in any way.