1617803 - [Feature Request] set 'mousebutton.4th.enabled' and 'mousebutton.5th.enabled' to 'false' to disables the side buttons on a gaming mouse on Ubuntu

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P5)

Description

[RagglenLove]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Following this tutorial: https://superuser.com/questions/1247367/how-to-disable-mouse-back-and-forward-shortcuts

1. Type about:config into Firefox's address bar
2. In the about:config search bar, search for "mousebutton.4th.enabled" and "mousebutton.5th.enabled" and set them both to "false"
3. Restart Firefox.

Actual results:

Following these steps does nothing.

Expected results:

Apparently, two years ago, setting "mousebutton.4th.enabled" and "mousebutton.5th.enabled" to "false" would disable the side buttons of a mouse, but now, setting these things doesn't disable the side buttons.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

They are available only on Windows, but you report it from Ubuntu. Did you test it on Windows?

Comment 2

[RagglenLove]

but you report it from Ubuntu. Did you test it on Windows?

My main operating system is Ubuntu. I don't have access to Windows.

They are available only on Windows

I did not know this. So, there is no way to disable the side buttons on a mouse on Firefox running on Ubuntu then? Because disabling the side buttons isn't an option for me since I do game on my PC with Steam, so I need those side buttons for that, but for Firefox, I have no need for them.

So, this becomes a feature request then.

Comment 3

[RagglenLove]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #1)

They are available only on Windows, but you report it from Ubuntu. Did you test it on Windows?

but you report it from Ubuntu. Did you test it on Windows?

My main operating system is Ubuntu. I don't have access to Windows.

They are available only on Windows

I did not know this. So, there is no way to disable the side buttons on a mouse on Firefox running on Ubuntu then? Because disabling the side buttons system wide isn't an option for me since I do game on my PC with Steam, so I need those side buttons for that, but for Firefox, I have no need for them.

So, this becomes a feature request then.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you, I think that we can add it onto GTK widget easily.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Comment 6

[RagglenLove]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #5)

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Tested out your test build and setting 'mousebutton.4th.enabled' and 'mousebutton.5th.enabled' to 'false' disables the side buttons on my gaming mouse.

Comment 7

[RagglenLove]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #5)

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Thank you for doing this, so when will this be added to mainline Firefox?

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to RagglenLove from comment #6)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #5)

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Tested out your test build and setting 'mousebutton.4th.enabled' and 'mousebutton.5th.enabled' to 'false' disables the side buttons on my gaming mouse.

Thank you. Do the buttons work normally when you reset the prefs?

(In reply to RagglenLove from comment #7)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #5)

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Thank you for doing this, so when will this be added to mainline Firefox?

75 or 76 (depending on review process).

Comment 9

[RagglenLove]

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #8)

(In reply to RagglenLove from comment #6)

(In reply to Masayuki Nakano [:masayuki] (he/him)(JST, +0900) from comment #5)

Here is a test build, could you test it? (4th button and 5th button cannot be tested with VMware...)
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cbZKiqEUQvKu1W3ygRxsyA/runs/0/artifacts/public/build/target.tar.bz2

Tested out your test build and setting 'mousebutton.4th.enabled' and 'mousebutton.5th.enabled' to 'false' disables the side buttons on my gaming mouse.

Thank you. Do the buttons work normally when you reset the prefs?

Yes, when I return 'mousebutton.4th.enabled' and 'mousebutton.5th.enabled' to 'true', the buttons work normally again.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1617803 - Support 4th and 5th mouse button disabling pref on Linux r=karlt

Some users may want to disable 4th and 5th button of mouse.
This feature has already been implemented on Windows, and
our GTK widget can support this with this simple patch.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thank you! Going to the review process.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/318fa53b5326
Support 4th and 5th mouse button disabling pref on Linux r=karlt

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/318fa53b5326