1617805 - Perma wgpu bustage "Building git equivalent for 8f51a5fac21cb52e2ddb647f0b99a9bfccb41f6a on top of None"

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Cristina Coroiu [:ccoroiu]]

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=7d59549f2fda3aed3927ab49b940d9024e161798

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=290307912&repo=mozilla-central

[task 2020-02-25T04:32:01.924Z] Running converter...
[task 2020-02-25T04:32:01.924Z] ~/checkouts/gecko ~
[task 2020-02-25T04:32:10.042Z] Using 0f1a8e4c6a76b3b0b16902c7fdfe2356c60ca351 as base hg revisions
[task 2020-02-25T04:32:10.042Z] Initial set has 651 changesets
[task 2020-02-25T04:32:10.042Z] Found hg tail revisions ['7b47a4c77243f843e583520a33e42adde78bda24']
[task 2020-02-25T04:32:10.042Z] Found common ancestor of tail revisions: 7b47a4c77243f843e583520a33e42adde78bda24
[task 2020-02-25T04:32:10.042Z] Pre-existing git commit 153c7f3f08ece7a1689f3cc4c69aec0632ac1468 from hg rev 0f1a8e4c6a76b3b0b16902c7fdfe2356c60ca351 is sufficiently old; stopping walk
[task 2020-02-25T04:32:10.042Z] Using hg rev 0f1a8e4c6a76b3b0b16902c7fdfe2356c60ca351 as common ancestor of all interesting changesets
[task 2020-02-25T04:32:10.042Z] Updated set has 652 changesets
[task 2020-02-25T04:32:10.042Z] Identified 3 changesets that touch the target code
[task 2020-02-25T04:32:10.042Z] Building git equivalent for 8f51a5fac21cb52e2ddb647f0b99a9bfccb41f6a on top of None
[task 2020-02-25T04:32:10.043Z] Traceback (most recent call last):
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 406, in <module>
[task 2020-02-25T04:32:10.043Z] git_tip = build_git_commits(hg_tip)
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 314, in build_git_commits
[task 2020-02-25T04:32:10.043Z] git_parent = build_git_commits(hg_commits[rev].parents[0])
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 314, in build_git_commits
[task 2020-02-25T04:32:10.043Z] git_parent = build_git_commits(hg_commits[rev].parents[0])
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 319, in build_git_commits
[task 2020-02-25T04:32:10.043Z] commit_obj = try_commit(rev, git_parent)
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 300, in try_commit
[task 2020-02-25T04:32:10.043Z] return real_commit(hg_rev, parent1, parent2)
[task 2020-02-25T04:32:10.043Z] File "/builds/worker/checkouts/gecko/tools/github-sync/converter.py", line 263, in real_commit
[task 2020-02-25T04:32:10.043Z] parent1_obj = downstream_git_repo.get(parent1)
[task 2020-02-25T04:32:10.043Z] File "/usr/local/lib/python3.5/dist-packages/pygit2/repository.py", line 113, in get
[task 2020-02-25T04:32:10.043Z] value = self.git_object_lookup_prefix(key)
[task 2020-02-25T04:32:10.043Z] TypeError
[taskcluster 2020-02-25 04:32:12.108Z] === Task Finished ===
[taskcluster 2020-02-25 04:32:12.108Z] Unsuccessful task run with exit code: 1 completed in 148.843 seconds

Comment 1

[Dzmitry Malyshau [:kvark]]

I suspect this broke because of bug 1616977

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Fixing bug summary to be more correct. The sparse-profile warning is unrelated. I can investigate.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1617805 - Don't prune hg revs that are referenced by git tags as boring. r?kvark

The git repo may have tags of the form 'mozilla-<rev>' which tell the
converter script that the git commit is synced from given mozilla-central
hg rev. Those git commits are likely to be created manually from mozilla-central
push heads, which may or may not contain changes to the code being synced.
In this instance, the push head being referenced by tag did not contain changes,
and so the rev was pruned as uninteresting to the conversion. This led to a
busted graph and failure during git commit building.

This patch ensures that any hg rev referenced by a git commit doesn't get
pruned as boring, and so can be used as a base to build additional git commits
on top of.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1617805 - Improve debug logging in converter script. r?kvark

Depends on D64135

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Once this gets merged to m-c, we'll want to manually trigger the wgpu job on an m-c push that includes these patches, so that it runs the script. Or we can just wait until the next change to gfx/wgpu which will trigger the job automatically.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49ae8c6c4bf6
Don't prune hg revs that are referenced by git tags as boring. r=kvark
https://hg.mozilla.org/integration/autoland/rev/1c64f6c1fe4f
Improve debug logging in converter script. r=kvark

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/49ae8c6c4bf6
https://hg.mozilla.org/mozilla-central/rev/1c64f6c1fe4f

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I triggered the job, it generated https://github.com/gfx-rs/wgpu/pull/504 which looks good

Comment 9

[Intermittent Failures Robot]

3 failures in 5233 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3

Platform breakdown:

• other: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1617805&startday=2020-02-24&endday=2020-03-01&tree=all