1617851 - Add basic location information for Ion aborts in non-debug builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[André Bargull [:anba]]

We don't want to call PCToLineNumber() in non-debug mode to avoid its runtime overhead, but we should still provide some basic script location information (script file name and function line and column).

This affects the "Script too large" Ion abort and IonBuilder::abort(), other Ion abort messages already provide sufficient script location information.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1617851: Add location information to Ion abort messages in non-debug mode. r=jandem!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9514a3c5e611
Add location information to Ion abort messages in non-debug mode. r=jandem

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 9514a3c5e611 (bug 1617851) for causing bustages
https://hg.mozilla.org/integration/autoland/rev/011ad9ff26088e341b0aebecd4424523b7759e88

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=busted&revision=9514a3c5e611a24d1dacd19b9daeb5e1cc1b2827&selectedJob=295805775

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5853dd0d7af
Add location information to Ion abort messages in non-debug mode. r=jandem

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c5853dd0d7af