1617878 - Give cloned derived class constructors scripted function types

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[André Bargull [:anba]]

Cloned derived class constructors are never inlined, because they don't have scripted function types installed. This is similar to the issues reported in bug 1606868 and bug 958797.

With scripted function types, the following µ-benchmark finishes ~3x faster than without the patch.

var make = base => class C extends base { constructor() { return {}; } };
var C = make(class {});

function f() {
    var xs = [null, null];
    var t = dateNow();
    for (var i = 0; i < 5000000; ++i) {
        xs[i & 1] = new C();
    }
    return dateNow() - t;
}

for (var i = 0; i < 10; ++i) print(f());

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1617878 - Part 1: Remove unused default parameters. r=jandem!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1617878 - Part 2: Replace remaining references to "parent" with "enclosingEnv". r=jandem!

In some places we were still using the old "parent" nomenclature, leading to
inconsistencies between function declarations and definitions, cf.
CloneFunctionReuseScript().

Depends on D64063

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1617878 - Part 3: Assign type for cloned derived class constructors. r=jandem!

Depends on D64064

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/080133f25701
Part 1: Remove unused default parameters. r=jandem
https://hg.mozilla.org/integration/autoland/rev/038f065c2bbe
Part 2: Replace remaining references to "parent" with "enclosingEnv". r=jandem
https://hg.mozilla.org/integration/autoland/rev/d93e9fef86dd
Part 3: Assign type for cloned derived class constructors. r=jandem

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/080133f25701
https://hg.mozilla.org/mozilla-central/rev/038f065c2bbe
https://hg.mozilla.org/mozilla-central/rev/d93e9fef86dd