1617889 - Fix COOP comparison

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

This is wrong, as it excludes same-origin-allow-popups

  if ((documentPolicy & nsILoadInfo::OPENER_POLICY_SAME_ORIGIN) &&
      documentOrigin->Equals(resultOrigin)) {

Comment 1

[Valentin Gosu [:valentin] (he/him)]

See the To match cross-origin opener-policies section at https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1617889 - Remove unneeded expectation files r=michal

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1617889 - Fix COOP comparison check r=michal

Depends on D64081

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1617889 - Fix CrossOriginOpenerPolicy inheritance from a cross origin iframe r=nika

Depends on D64083

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1617889 - COOP: Open new windows as "noopener" when origins don't match r=nika

If current's top-level browsing context's active document's cross-origin
opener-policy is "same-origin" or "same-origin + COEP", then:

• Let currentDoc be current's active document.
• If currentDoc's origin is not same origin with currentDoc's top-level
  origin, then set noopener to true.

https://gist.github.com/annevk/6f2dd8c79c77123f39797f6bdac43f3e#changes-to-choosing-a-browsing-context

Depends on D65524

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29444a6692c2
Remove unneeded expectation files r=michal
https://hg.mozilla.org/integration/autoland/rev/9842e5475b0b
Fix COOP comparison check r=michal
https://hg.mozilla.org/integration/autoland/rev/1b6ef44fd48d
Fix CrossOriginOpenerPolicy inheritance from a cross origin iframe r=nika
https://hg.mozilla.org/integration/autoland/rev/91cb5f31a5e2
COOP: Open new windows as "noopener" when origins don't match r=nika

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1617889 - Update expected fail on linux64 QuantumRender debug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/921af6c42e05
Update expected fail on linux64 QuantumRender debug. CLOSED TREE

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/29444a6692c2
https://hg.mozilla.org/mozilla-central/rev/9842e5475b0b
https://hg.mozilla.org/mozilla-central/rev/1b6ef44fd48d
https://hg.mozilla.org/mozilla-central/rev/91cb5f31a5e2
https://hg.mozilla.org/mozilla-central/rev/921af6c42e05