161791 - Save As dialog of mail compose window can't handle non-ASCII filename

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Koike Kazuhiko]

Save As dialog of mail compose window can't handle non-ASCII
filename.

(1) Open a mail compose window.
(2) Select [File]-[Save As]-[File], enter a non-ASCII filename
 and save it.
(3) Select [File]-[Save As]-[File] again.

Actual result: Filename is displayed in escaped string.

Expected result: Filename is displayed as it was entered.

Build: 2002080808-trunk/Linux

Original report in Bugzilla-jp:
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=2505

Comment 1

[marina]

dup of 155659?

Comment 2

[marina]

i meant to say bug # 155569.

Comment 3

[nhottanscp]

> (2) Select [File]-[Save As]-[File], enter a non-ASCII filename
>  and save it.
> (3) Select [File]-[Save As]-[File] again.

For both 2 and 3, I see the default string "message.eml" as a file name.
Koike san, could you attach a screen shot of the problem?

Comment 4

[Koike Kazuhiko]

Attachment: Screenshot

(1) Enter <kanji> and save it.
(2) Open "Save As" dialog again.

Comment 5

[nhottanscp]

I can reproduce it, thanks.

Comment 6

[Isaac Hwak Han]

Attachment: simple fix

bug 168788 looks similar.

Comment 7

[Makoto Kato [:m_kato]]

Reproduce on 3.1 (20100405)

Comment 8

[Makoto Kato [:m_kato]]

Attachment: patch

Comment 9

[[e-mail]]

Comment on attachment 437270 [details] [diff] [review]
patch

Unfortunately there is a minor regression when using SeaMonkey Composer to edit pages containing certain special characters, for example if you edit http://en.wikipedia.org/wiki/%5C on Windows and then try to Save As the suggested filename is \.html rather than, say, _.html which would have been suggested had you created a new page with a title of \.

Comment 10

[Makoto Kato [:m_kato]]

Attachment: patch v2

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 437528 [details] [diff] [review]
patch v2

unescape on file:// only

Comment 12

[[e-mail]]

That's a shame because I liked the way the original fixed up the suggested file name of other Wikipedia pages...

Comment 13

[[e-mail]]

That's a shame because I liked the way the original patch fixed up the suggested file name of other Wikipedia pages...

Comment 14

[Makoto Kato [:m_kato]]

(In reply to comment #13)
> That's a shame because I liked the way the original patch fixed up the
> suggested file name of other Wikipedia pages...

Neil, Is there a interface or method to generate normalized file name from string?

Comment 15

[[e-mail]]

GetSuggestedFileName already calls GenerateValidFilename to clean up the page title to use as a file name, but that function is deprecated and you should try to use the validateFileName function if you can.

Comment 16

[Makoto Kato [:m_kato]]

Thank you, neil.  I will try it.

Comment 17

[Makoto Kato [:m_kato]]

Attachment: patch v3

Comment 18

[[e-mail]]

Comment on attachment 437776 [details] [diff] [review]
patch v3

No wonder GenerateValidFilename is deprecated; validateFileName looks so much nicer to use :-)

Comment 19

[Makoto Kato [:m_kato]]

landed
http://hg.mozilla.org/comm-central/rev/9a96ffdd6081