1617940 - Review styling of focus indicator for `<select>` when native theme is disabled

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P3)

Description

[Stephen A Pohl [:spohl]]

From bug 1381938 comment 41:

• <select> now lacks any visible focus indicator.

• In its hover behaviour, <select> is now styled more like a button than a textbox, which is contrary to how Windows has always (literally always; I can think of no counterexamples ever) treated them (though in line with most of macOS, where the distinction is fairly subtle, and in line with GTK, where the difference is huge and quite obnoxious).

Comment 1

[Stephen A Pohl [:spohl]]

n-i :shorlander to get his input on comment 0.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Fwiw, bug 1624708 added focus indicators for select as well. The other questions are still open of course.

Comment 3

[Stephen A Pohl [:spohl]]

Changing bug title to reflect the fact that we now have focus indicators. See comment 0 for the remaining UX questions.

Comment 4

[Chris Peterson [:cpeterson]]

Tracking non-native theming bugs for Fission Beta milestone (M7).

Comment 5

[Neha Kochar [:neha]]

This is currently marked as blocking NNT for Windows, which in-itself is not a Fission blocker so removing Fission milestone from this bug. If this turns out to be required for NNT on Linux (blocking Fission M7) please add back the Fission milestone.

Comment 6

[Chris Peterson [:cpeterson]]

Stephen, what work is left to do for this bug about the <select> focus indicator? Does this work relevant to all platforms?

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Stephen A Pohl [:spohl] from comment #0)

• In its hover behaviour, <select> is now styled more like a button than a textbox, which is contrary to how Windows has always (literally always; I can think of no counterexamples ever) treated them (though in line with most of macOS, where the distinction is fairly subtle, and in line with GTK, where the difference is huge and quite obnoxious).

Sounds like this bug to review the <style> focus indicator is only about Windows if the current behavior is already in line with macOS and GTK.

Comment 8

[Stephen A Pohl [:spohl]]

Yes, I agree. I don't believe that this should block the initial enabling of the non-native theme, but it's good to have this bug on file to revisit this issue.

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to Stephen A Pohl [:spohl] from comment #0)

From bug 1381938 comment 41:

• <select> now lacks any visible focus indicator.

• In its hover behaviour, <select> is now styled more like a button than a textbox, which is contrary to how Windows has always (literally always; I can think of no counterexamples ever) treated them (though in line with most of macOS, where the distinction is fairly subtle, and in line with GTK, where the difference is huge and quite obnoxious).

Stephen, is this bug fixed? AFAICT, <select> elements have reasonable focus and hover behavior on Windows 10.

Examples of <select> elements for testing:

http://stephenhorlander.com/photon/UI-Controls/form-widgets.html

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

Comment 10

[Stephen A Pohl [:spohl]]

(In reply to Chris Peterson [:cpeterson] from comment #9)

(In reply to Stephen A Pohl [:spohl] from comment #0)

From bug 1381938 comment 41:

• <select> now lacks any visible focus indicator.

• In its hover behaviour, <select> is now styled more like a button than a textbox, which is contrary to how Windows has always (literally always; I can think of no counterexamples ever) treated them (though in line with most of macOS, where the distinction is fairly subtle, and in line with GTK, where the difference is huge and quite obnoxious).

Stephen, is this bug fixed? AFAICT, <select> elements have reasonable focus and hover behavior on Windows 10.

Examples of <select> elements for testing:

http://stephenhorlander.com/photon/UI-Controls/form-widgets.html

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select

Yes, I believe it is. Since this was reported by Chris in bug 1381938 I'd like for him to confirm.

Comment 11

[Chris Morgan]

Sorry I forgot to confirm this. Yes, this is reasonable now. Thanks for the improvements, they’re good.

Comment 12

[Stephen A Pohl [:spohl]]

Thanks for confirming!