1617986 - [wpt-sync] Sync PR 21966 - [Payment Handler] CanMakePaymentEvent.respondWithMinimalUI()

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21966 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21966
Details from upstream follow.

Rouslan Solomakhin <[e-mail]> wrote:

[Payment Handler] CanMakePaymentEvent.respondWithMinimalUI()

Patch #2: Parsing and validating the parameters of
CanMakePaymentEvent.respondWithMinimalUI() in Blink.

The respondWithMinimalUI() method is disabled by default and can be
enabled via chrome://flags/#enable-experimental-web-platform-features.

Explainer:
https://gist.github.com/rsolomakhin/eba91c185028899883d2c7f37f357d7c

Demo: https://rsolomakhin.github.io/pr/apps/micro/
Test: wpt/payment-handler/respond-with-minimal-ui.https.html

Chrome feature status:
https://chromestatus.com/feature/5661524146257920

Blink-dev intent to prototype:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/kTLpgFJz6Ck/IQeiGDtOAwAJ

Bug: 1005076
Change-Id: I1573cef83d357046144d198e870c7f3fd54fd976
Reviewed-on: https://chromium-review.googlesource.com/2072582
WPT-Export-Revision: 427c2ac3b85620878b574c634da225bd7cae2fb6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3377ac70b80b28341e31d5a5ccc371ca7e18d45

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
FAIL: 8

Safari

OK : 1
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/payment-handler/respond-with-minimal-ui.https.html
respondWithMinimalUI({}) causes hasEnrolledInstrument() to return "false": FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: true, readyForMinimalUI: true, accountBalance: "6.78"}) does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI(0) causes hasEnrolledInstrument() to return "false": FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: true}) causes hasEnrolledInstrument() to return "true": FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: true, readyForMinimalUI: true, accountBalance: "--"}) does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: false}) causes hasEnrolledInstrument() to return "false": FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: true, readyForMinimalUI: true, accountBalance: ""}) does not crash: FAIL (Chrome: FAIL, Safari: FAIL)
respondWithMinimalUI({canMakePayment: true, readyForMinimalUI: true}) does not crash: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ded8c5a9f143
[wpt PR 21966] - [Payment Handler] CanMakePaymentEvent.respondWithMinimalUI() #2, a=testonly

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ded8c5a9f143