1618000 - Max blur radius should be applied after scale factors are applied

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Connor Brewster [:cbrewster]]

Attachment: testcase.html

We currently apply the max blur radius to blur/drop-shadow filters before applying scale factors.

The non-WR path appears to apply the max blur radius afterwards. Additionally this will prevent the blur radius from exceeding the maximum blur amount regardless of the scale factors.

Comment 1

[Connor Brewster [:cbrewster]]

Attachment: testcase-wr

Comment 2

[Connor Brewster [:cbrewster]]

Attachment: testcase-non-wr

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Connor, are you going to try to fix this?

Comment 4

[Connor Brewster [:cbrewster]]

Sure! I think the fix should be somewhat straight-forward.

Comment 5

[Connor Brewster [:cbrewster]]

Attachment: Bug 1618000: Part 1: Remove blur radius clamping on Gecko-side for WR blur filters

Clamping of the blur radius depends on transform scale factors. This info is not available until later in the WebRender pipeline, so we need to delegate blur radius clamping to WebRender.

Comment 6

[Connor Brewster [:cbrewster]]

Attachment: Bug 1618000: Part 2: Clamp blur radius based on scale factors

Depends on D65804

Comment 7

[Tim Nguyen :ntim]

Hi Connor, do you know if it's a recent regression? Just wondering if this should be uplifted to Beta 75 :)

Comment 8

[Connor Brewster [:cbrewster]]

This is not really a regression, as it was never handled correctly. However, this became a bigger issue after Bug 1499113, as it allows you to create a scenario where you can bypass the max blur radius by using a scale transform. (I was able to crash FF by using a very large scale amount)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e720691ccf17
Part 1: Remove blur radius clamping on Gecko-side for WR blur filters r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/a561435c24cf
Part 2: Clamp blur radius based on scale factors r=gfx-reviewers,nical

Comment 10

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (Bug 1618000) for causing reftest failures in feGaussianBlur-5-ref.svg CLOSED TREE.

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=292627789

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292627789&repo=autoland&lineNumber=3056

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c027d62be50
Backed out 2 changesets for causing reftest failures in feGaussianBlur-5-ref.svg CLOSED TREE

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bc71e7b317b
Part 1: Remove blur radius clamping on Gecko-side for WR blur filters r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/c72b18b22267
Part 2: Clamp blur radius based on scale factors r=gfx-reviewers,nical

Comment 13

[Razvan Maries]

Backed out for Wrench bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2Cx64%2Cquantumrender%2Copt%2Cwebrender%2Cstandalone%2Cwebrender-linux-release%2Cwr%28wrench%29&revision=c72b18b2226756ea8e861ff45f7255b780b93ca1&selectedJob=294398547

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294398547&repo=autoland&lineNumber=13432

Backout: https://hg.mozilla.org/integration/autoland/rev/fc4c4e983d42d9bf0600385276e6e23c22a7eaa9

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/077c46d3381c
Part 1: Remove blur radius clamping on Gecko-side for WR blur filters r=gfx-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/3feaf53352b8
Part 2: Clamp blur radius based on scale factors r=gfx-reviewers,nical

Comment 15

[Connor Brewster [:cbrewster]]

Attachment: Bug 1618000: Part 3: Remove accidental dbg macro

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/171275c408d1
Part 3: Remove accidental dbg macro r=tnikkel

Comment 17

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/077c46d3381c
https://hg.mozilla.org/mozilla-central/rev/3feaf53352b8
https://hg.mozilla.org/mozilla-central/rev/171275c408d1