1618017 - [wpt-sync] Sync PR 21972 - bluetooth: getDevices() implementation

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21972 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21972
Details from upstream follow.

Ovidio Henriquez <[e-mail]> wrote:

bluetooth: getDevices() implementation

This change implements getDevices() which returns a list of
WebBluetoothDevice objects that the current site has permission to
access. If the kWebBluetoothNewPermissionsBackend flag is enabled, the
list of devices will contain all of the permitted devices. If the flag
is not enabled, then the list of devices will contain the permitted
devices that are currently connected to the system.

Design doc:
https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/edit#heading=h.5ugemo7p04z9

Bug: 577953
Change-Id: I9785f24ee46ac634b6a96d6146f54da37d132a4e
Reviewed-on: https://chromium-review.googlesource.com/2044660
WPT-Export-Revision: 442db9c2c6efdfc0d53a877b4d0dad1d2aaba7a8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e739dfe1d9c94dc03309690133623bfdb2bce89c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 50 tests

Status Summary

Firefox

OK : 4
PASS: 46
FAIL: 4

Chrome

OK : 4
FAIL: 4

Safari

OK : 4
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/bluetooth/idl/idl-Bluetooth.https.html
Bluetooth IDL test: FAIL (Chrome: FAIL, Safari: FAIL)
/bluetooth/getDevices/no-granted-devices.https.window.html
getDevices() resolves with empty array if no device permissions have been granted.: FAIL (Chrome: FAIL, Safari: FAIL)
/bluetooth/getDevices/granted-devices-with-services.https.window.html
getDevices() resolves with permitted devices that can be GATT connected to.: FAIL (Chrome: FAIL, Safari: FAIL)
/bluetooth/getDevices/returns-same-bluetooth-device-object.https.window.html
multiple calls to getDevices() resolves with the sameBluetoothDevice objects for each granted Bluetooth device.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/356e5e3535b4
[wpt PR 21972] - bluetooth: getDevices() implementation, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1c6439903ffe
[wpt PR 21972] - Update wpt metadata, a=testonly

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/356e5e3535b4
https://hg.mozilla.org/mozilla-central/rev/1c6439903ffe