Closed Bug 1618080 Opened 5 years ago Closed 4 years ago

Investigate ensuring that the device selector can render to its full height in ui.js

Categories

(DevTools :: Responsive Design Mode, task, P3)

Product:
DevTools
Component:
Responsive Design Mode
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mtigley, Assigned: mtigley)

References

Details

This is a follow-up to Bug 1604726 where the parent container (App.js) needs to reach up to its parent document (<iframe class="rdm-toolbar">) to ensure that a height is fixed so that the DeviceSelector component can be shown. The reason why this isn't done in ui.js instead is that updating the device selector there is async, so by the time "update-device-toolbar-height" is received, it's already too late.

This bug investigates finding a better way to synchronously set the height of the toolbar without having to use the above approach. We should be able to handle this in ui.js

Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Depends on: 1620098

Resolving as FIXED now that Bug 1620098 has landed.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.