1618085 - Unnecessary calls to aCellFrame->GetRowSpan() and aCellFrame->GetColSpan() in nsCellMap::RemoveCell

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement)

Description

[Alex Henrie]

nsCellMap::RemoveCell currently has the following code:

  bool spansCauseRebuild = CellsSpanInOrOut(aRowIndex, aRowIndex + rowSpan - 1,
                                            startColIndex, numCols - 1);
  // XXX if the cell has a col span to the end of the map, and the end has no
  // originating cells, we need to assume that this the only such cell, and
  // rebuild so that there are no extraneous cols at the end. The same is true
  // for removing rows.
  if (!aCellFrame->GetRowSpan() || !aCellFrame->GetColSpan())
    spansCauseRebuild = true;

In other functions in this class with similar logic, there is an outer if (!spansCauseRebuild) to skip the extra checks if we already know that a rebuild is required. We should do the same here because calling a function in another module can be expensive compared to if statements which are practically free.

Comment 1

[Alex Henrie]

Attachment: Bug 1618085 - Avoid calling Get(Row|Col)Span unnecessarily in nsCellMap::RemoveCell.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7887ba587ec
Avoid calling Get(Row|Col)Span unnecessarily in nsCellMap::RemoveCell. r=dbaron

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b7887ba587ec