1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

The typedefs

typedef BaseAutoLock<Mutex&> MutexAutoLock;
typedef BaseAutoLock<OffTheBooksMutex&> OffTheBooksMutexAutoLock;

are no longer necessary and deduction guides can be used instead to handle any Mutex reference.

BaseAutoLock can be renamed to MutexAutoLock and a deduction guide

template <typename MutexType>
MutexAutoLock(MutexType&)->MutexAutoLock<MutexType&>;

be defined instead.

All uses of BaseAutoLock and OffTheBooksMutexAutoUnlock must be changed to refer to MutexAutoLock in the course of this.

The same applies to BaseAutoUnlock etc.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Sorry, I was mistaken about the typedefs being no longer needed, they are required for use in function signatures. But still the deduction guides should be added to allow you to write:

BaseAutoLock lock(mutexOfTemplatedType);

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1618165 - Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj

Depends on D64358

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ce0a07d782
Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj

Comment 4

[Razvan Maries]

Backed out for build bustages on WeakRef.cpp and ThreadAnnotation.cpp.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=290832773&resultStatus=testfailed%2Cbusted%2Cexception&revision=b6ce0a07d782451a3fc8e58f59b3e480b4bc2cdd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290832773&repo=autoland&lineNumber=57480
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290832791&repo=autoland&lineNumber=22260

Backout: https://hg.mozilla.org/integration/autoland/rev/bf16543bd985597dd9a97840f1b6ef0badbea865

Comment 5

[Simon Giesecke [:sg] [he/him]]

Updated patch to fix Windows and OS X builds.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d992fd39a39
Provide BaseAutoLock and BaseAutoUnlock deduction guides for Mutex references. r=froydnj

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5d992fd39a39