161817 - Universal autodetector doesn't get installed

Status: RESOLVED FIXED

(Core Graveyard :: Installer: GRE, defect)

Description

[marina]

in today's 2002-08-08-1.0 build Universal autodetect is not on the menu.It was
there yesterday. Screen shot to follow

Comment 1

[marina]

Attachment: here is a screen shot of the menu, if you go to the whole list under Customize you'll see it is mising

Comment 2

[Yuying Long]

It works for me on same 08-08-08 1.0 build.

Marina, could you please try use a new profile to see if still see it?

Comment 3

[marina]

i actually logged it for the new profile, i see it with a new profile with
2002-08-08-1.0 build

Comment 4

[Roy Yokoyama]

marina: >i see it with a new profile with 2002-08-08-1.0 build 
        so which build is having problem?  

Comment 5

[marina]

i am referring to the 2002-08-08 branch build

Comment 6

[Yuying Long]

I installer 08-09 1.0 branch build on both WinXP-JA(recommended) and
WinME-JA(full), I don't see this problem, auto-detect Universal is listed there.

Comment 7

[marina]

here is what's happening: if i run Uninstall first and install even in the same
directory i see Universal in the build (dll is under components). If i run the
installation without uninstall then i don't see it (it started to happen with
08-08 build. With previous builds even without running uninstall first i would
get the Universal listed...) Invalid ?(because it is recommended to uninstall
first)?

Comment 8

[Roy Yokoyama]

I think it's more like INVALID; but I think we should let xpinstall guys
to know.  This may impact other files too.

dveditz: what do you think?  marina is experiencing missing a dll when installed
         on the same directory without performing uninstall first.  
         Are we deleting file(s) duing installation?

Comment 9

[marina]

another fact: without Uninstall but installing into different directories(one
branch, one trunk) and swtiching between branch and trunk i am loosing a dll
(Universal autodetect)

Comment 10

[Jani Patokallio]

This seems to have shown up again in Mozilla 1.2 and 1.2.1, at least under WinNT
 -- Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.2.1) Gecko/20021130 to be
quite exact.  Universal autodetect showed up and worked just fine on 1.2beta,
but now it's simply missing from the Character Coding menu.

Comment 11

[Timothy Lee]

Under Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030205, the
Universal detector is missing from the CharCoding->AutoDetect menu.  Un-install
followed by install doesn't fix the problem.

Comment 12

[Yuying Long]

I saw universal detector on 02-06 windows build, I did uninstall and installed
into a new directory.

Comment 13

[Jun MUTO]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030208

I cannot see Universal detector on installer build 
(2003-02-08-04-trunk/mozilla-win32-installer-sea.exe) too.

Comment 14

[marina]

copying Sean comments from teh bugscape bug:
------- Additional Comment #7 From Sean Su  2003-02-13 13:03 -------

yes, that used to be one of the problems.  the .dll now gets installed into the
GRE's componend dir, so that delete statement is actually correct now.

However, commercial installers still package the .dll into the browser.xpi,
which it should no longer do since GRE installs the file now.

Comment 15

[Sean Su]

over to me

Comment 16

[Teruko Kobayashi]

Changed component.

Comment 17

[Charles Rosendahl]

Is this fixed?  Which dll are people referring to here? looks like a packaging
issue in the commercial build?

Comment 18

[Teruko Kobayashi]

universalchardet.dll does not get installed.

Comment 19

[Sean Su]

the universalchardet.dll file is no longer being installed into
[mozilla/netscape dir]\components folder.  It is part of GRE, which means that
it's installed into:
  [Program files]\Common Files\mozilla.org\GRE\1.4a_[build id]\components

to see universalchardet.dll in the mozilla installer, do this:
  1) run: mozilla-win32-installer-sea.exe -u
  2) run: unzip gre-win32-installer.zip
  3) run: gre-win32-installer.exe -u
  4) run: unzip gre.xpi

universalchardet.dll should be in: gre\components\universalchardet.dll

By the way, I do see the 'View|Character Coding|Auto Detect' menu.  It's working
for me.

Comment 20

[Charles Rosendahl]

wfm as well.

Comment 21

[marina]

Sean, you should see 'View|Character Coding|Auto Detect|Universal menu, do you
see that?

Comment 22

[Sean Su]

yes, I do see the 'Universal' menu within the 'View|Character Coding|Auto
Detect' menu in today's build.

Comment 23

[marina]

i would like to do some testing on this bug with several installation scenarios,
i will reopen this bug till IQA have results

Comment 24

[Charles Rosendahl]

not critical, as it works for me on all window platforms using the latest GREs.

Comment 25

[Sean Su]

I think I found out why universalchardet.dll appears to get installed in the
commercial build, then it appears that it doesn't all of a sudden.

The problem is that the commercial's packages-win still lists
universalchardet.dll to be packaged up in browser.xpi.

And since browser.jst contains a command to delete universalchardet.dll from the
browser's component dir (because it's now in GRE), universalchardet.dll shows up
on the hard drive on *every other* installation.  This is due to a "quirk" in
the delete command in browser.jst.

The fix is to remove universalchardet.dll from the commercial's packages-win. 
What this will do is have only universalchardet.dll be installed with GRE, not
the commercial browser anymore.

I'm assuming that we only wanted universalchardet.dll to be installed with GRE,
not the browser.  Is this correct?

Comment 26

[bobj]

> I'm assuming that we only wanted universalchardet.dll to be installed with GRE,
> not the browser.  Is this correct?

Yes.

Comment 27

[Samir Gehani]

adt: nsbeta1+/adt2

Comment 28

[Sean Su]

bug 205514 is fixed.  closing this bug as fixed as well.  reopen if problem
still persists.