1618215 - Set correct resolvers in doh-rollout.trrRace.trrList

Status: VERIFIED FIXED

(Firefox :: Security, task, P1)

Description

[Johann Hofmann [:johannh]]

[Tracking Requested - why for this release]:
Necessary update for TRR performance experiment

When we figure out the correct set of resolvers, we want to set this pref and uplift it before launching the experiment.

Comment 1

[Pascal Chevrel:pascalc]

The last beta is built tonight (4AM UTC), can we get this figured out and uplifted before Monday's merge?

Comment 2

[Johann Hofmann [:johannh]]

Yup, doing it now :)

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1618215 - Set correct resolvers in doh-rollout.trrRace.trrList. r=dragana,valentin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8303311bf87b
Set correct resolvers in doh-rollout.trrRace.trrList. r=dragana

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8303311bf87b

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9129545 [details]
Bug 1618215 - Set correct resolvers in doh-rollout.trrRace.trrList. r=dragana,valentin

Beta/Release Uplift Approval Request

• User impact if declined: Needed for DoH Performance experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: This will enable testing of the experiment without setting the additional pref
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a very simple change to a pref fallback
• String changes made/needed: None

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9129545 [details]
Bug 1618215 - Set correct resolvers in doh-rollout.trrRace.trrList. r=dragana,valentin

P1 and covered by tests, uplift accepted for the beta branch, thanks.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/61fc5620c3f5

Comment 9

[Patriciu Pop [:ppop], Ecosystem QA]

I have verified that the resolvers list is correctly set and the experiment can be tested without setting the "doh-rollout.trrRace.trrList" preference manually. Tested using Firefox Nightly 75.0a1 Build ID 20200302094818 on Windows 10 x64, macOS 10.15.2 and Ubuntu 18.

I will retest this on the Beta channel when 74.0b10 will be available and set the flags accordingly.

Comment 10

[Patriciu Pop [:ppop], Ecosystem QA]

I have also verified this using Firefox Beta 74.0 RC on Windows 10 x64, macOS 10.15.2 and Ubuntu 18.