1618229 - The “Dismiss” button’s icon does not respect the browser’s “Dark” theme colors scheme when hovered

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Robert Martin [:romartin], Ecosystem QA]

Attachment: 2020-02-26_17h11_30.gif

[Affected versions]:

• Firefox Nightly 75.0a1 Build ID 20200226092757

[Affected Platforms]:

• Windows 10 x64
• macOS 10.15
• Arch Linux 5.3.6 x64

[Prerequisites]:

• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.endpoints set to http,https.
• Have the value of the pref browser.newtabpage.activity-stream.discoverystream.config set to {"api_key_pref":"extensions.pocket.oAuthConsumerKey","collapsible":true,"enabled":true,"show_spocs":true,"hardcoded_layout":false,"personalized":true,"layout_endpoint":"https://e5e8374d-fffa-4a77-a604-31603852b6fd.mock.pstmn.io/1615081-layout"}.
• Have the value of the pref browser.search.region set to US.
• The “Dark” theme is enabled in the “Themes” section located in “about:addons”.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Open a new tab.
3. Hover the “Dismiss” button.
4. Observe the “Dismiss” button’s icon color.

[Expected result]:

• The “Dismiss” icon color respects the “Dark” theme colors. (#F9F9FA, Grey 10)

[Actual result]:

• The “Dismiss” icon color is #2A2A2E.

[Notes]:

• Attached a screen recording of the issue.

Comment 1

[Gavin Suntop [:gvn] (they/them)]

Attachment: fixing dismiss icon color on hover for dark mode

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d862601316f4
fixing dismiss icon color on hover for dark mode r=thecount

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d862601316f4

Comment 4

[Maria Heres, inactive, contact Ecosystem QA]

I have verified that this issue is no longer reproducible on Nightly 75.0a1 (Build ID: 20200303214128) on Windows 10 x64, Mac 10.15, Mint 19.2 Tina. The dark theme color scheme is now respected on hover.
An additional pref change besides the ones in the Prerequisites was necessary to trigger the Dismiss button: browser.newtabpage.activity-stream.discoverystream.isCollectionDismissible set to true.