1618277 - Error "Normal not defined" when visiting certain websites, works in previous versions

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Evelyn Henry]

Trying to browse for example: https://www.maine.gov/geolib/ediscovery/site/index.html results in the map not loading properly and an error in the console "Normal not defined" being posted in 73.0.1 and 74. Works in 73.0.0 and previous versions. Regression range wanted.

Comment 1

[Michael Cooper [:mythmon]]

Mozregression says that bug 1605803 caused this.

 4:34.22 INFO: No more integration revisions, bisection finished.
 4:34.22 INFO: Last good revision: 0845f6adc5772380382cc5db616db4880a9f27a8
 4:34.22 INFO: First bad revision: fc3002cb85dc4d2c44d8aec1246f0356097411e3
 4:34.22 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0845f6adc5772380382cc5db616db4880a9f27a8&tochange=fc3002cb85dc4d2c44d8aec1246f0356097411e3

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This site doesn't work in other browsers either... They were effectively relying on a place where browsers were inconsistent and it broke when we fixed it.

Ksenia, what is the usual way to deal with this? Their script has: if(_a7a&&_a7a!="none"){_a73([eval(_a7a)],_a74);}else{_a74();}. It'd work in all browsers if they did _a7a&&_a7a!="none"&&_a7a!="normal".

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

added link to the SUMO question

Comment 4

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

This site doesn't work in other browsers either... They were effectively relying on a place where browsers were inconsistent and it broke when we fixed it.

in my testing of other browsers: https://www.maine.gov/geolib/ediscovery/site/index.html

1. works on Windows 10, Edge Legacy (i.e. non Chrome version of Edge)
2. doesn't work on Windows 10, Chrome 80
3. works on OSX Catalina, Safari 13.0.5
4. doesn't work on OSX Catalina, Chrome 80

.

Comment 5

[Ksenia Berezina [:ksenia]]

Looks like it has been fixed by the site.

The code that was causing this error is part of xstyle framework. They've accounted for this in their recent version https://github.com/kriszyp/xstyle/blob/master/css.js#L57. Looks like the site was using an older version of the framework

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Alright then.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Thanks Ksenia!