Incorrect installed file set on non-Linux OS's using gtk
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mforney, Assigned: mforney)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0
Steps to reproduce:
Built firefox on several operating systems through pkgsrc (Linux, NetBSD), all of which use GTK, then compared the installed file lists.
Actual results:
The list of installed files unexpectedly differed in several places (see https://github.com/NetBSD/pkgsrc/commit/578023c8cbcb59b197d696977e0c029aaefc0e9b). This indicates that some files were installed when they shouldn't be, or not installed when they should be.
Installed on NetBSD, but not Linux:
/usr/lib/firefox/browser/chrome/browser/skin/classic/browser/import-export.svg
/usr/lib/firefox/browser/chrome/browser/skin/classic/browser/sort.svg
Installed on Linux, but not NetBSD:
/usr/lib/firefox/fonts/TwemojiMozilla.ttf
/usr/lib/firefox/browser/features/formautofill@mozilla.org/chrome/res/autocomplete-item.css
/usr/lib/firefox/browser/features/formautofill@mozilla.org/chrome/res/editDialog.css
Expected results:
/usr/lib/firefox/browser/chrome/browser/skin/classic/browser/import-export.svg
/usr/lib/firefox/browser/chrome/browser/skin/classic/browser/sort.svg
These files are referenced only by browser/themes/osx/places/organizer.css and browser/themes/windows/places/organizer.css, which are only used when MOZ_WIDGET_TOOLKIT is cocoa or windows. However, they are installed when XP_LINUX is not defined. Instead, they should be installed when MOZ_WIDGET_GTK is not defined.
/usr/lib/firefox/fonts/TwemojiMozilla.ttf
TwemojiMozilla.ttf is needed for gfx/thebes/gfxPlatformGtk.cpp (built when MOZ_WIDGET_TOOLKIT is gtk) and gfx/thebes/gfxWindowsPlatform.cpp (built when MOZ_WIDGET_TOOLKIT is windows). However, it is installed only when OS_ARCH is WINNT or Linux. Instead, it should be installed when MOZ_WIDGET_TOOLKIT is windows or gtk.
/usr/lib/firefox/browser/features/formautofill@mozilla.org/chrome/res/autocomplete-item.css
/usr/lib/firefox/browser/features/formautofill@mozilla.org/chrome/res/editDialog.css
I'm not sure about these. I believe they are needed by other non-Linux operating systems using GTK, but I'm not sure if the conditions in browser/extensions/formautofill/moz.build should be switched to use MOZ_WIDGET_TOOLKIT. I believe this depends on whether the linux formautofill skin is used on Android as well as GTK.
TwemojiMozilla.ttf is used on all GTK platforms, not just Linux.
import-export.svg and sort.svg aren't used on GTK platforms, so
they shouldn't be installed for non-Linux GTK platforms.
autocomplete-item.css and editDialog.css are used on all GTK
platforms, not just Linux.
|
||
Comment 2•4 years ago
|
||
Bugbug thinks this bug should belong to this component, but please revert this change in case of error.
|
||
Updated•4 years ago
|
Pushed by btara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc20bf1a0087 Fix installed file conditions on non-Linux platforms using GTK r=dao
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•