1618445 - Add better logging to process switching code

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P1)

Description

[Paul Bone [:pbone]]

Add better logging (printf debugging ;-) ) to process switching code to make it easier to make changes and find problems.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 1. Improve logging in SessionStore.jsm r=mattwoodrow

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 2. Move process switch logging to E10SUtils r=mattwoodrow

• Create new logger.
• Use logger for process switch logging.
• Remove "[process-switch]: " string from log messages, it is redundant.

This may eventually move to a whole new module if/when process switching
moves there.

Depends on D65439

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 3. Move session store logging into SessionStoreInternal r=mattwoodrow

Depends on D65440

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 4. Use the new logger for existing E10SUtils debug messages r=mattwoodrow

Depends on D65441

Comment 5

[Paul Bone [:pbone]]

FYI mattwoodrow,

I may add more patches yet, especially to debug E10SUtils methods like getRemoteTypeForURIObject and shouldLoadURI and friends.

Comment 6

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 5. Add logging to validatedWebRemoteType() r=mattwoodrow

It might not be clear from the diff (at least from mercurial it's not) but
I've moved the internals of validatedWebRemoteType() into an inner function
to make the logging calls before/after it easier to see together.

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1618445 - pt 6. Add some logging to shouldLoadUri r=mattwoodrow

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c09a442d8ddf
pt 1. Improve logging in SessionStore.jsm r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/79ae5f86d927
pt 2. Move process switch logging to E10SUtils r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/439d0b9ba0fc
pt 3. Move session store logging into SessionStoreInternal r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/846b67024a9a
pt 4. Use the new logger for existing E10SUtils debug messages r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4281c434f737
pt 5. Add logging to validatedWebRemoteType() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/0a996e80d92a
pt 6. Add some logging to shouldLoadUri r=mattwoodrow

Comment 9

[Narcis Beleuzu [:NarcisB]]

Backed out for leaks at mozilla::dom::Console::CreateInstance

Backout link: https://hg.mozilla.org/integration/autoland/rev/46fc24cc6656749d7f9593517c3f526ebf4d4030
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293456600&repo=autoland&lineNumber=34183

Comment 10

[Paul Bone [:pbone]]

Thanks Narcis,

I spoke with mcrr8 and he suggested whitelisting these leaks. Seems to be working on try and I'm landing again now.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83770ec96b2e
pt 1. Improve logging in SessionStore.jsm r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/65357be13f82
pt 2. Move process switch logging to E10SUtils r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/4665050e46f0
pt 3. Move session store logging into SessionStoreInternal r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/d9ea56821b1a
pt 4. Use the new logger for existing E10SUtils debug messages r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/7244027ef6ed
pt 5. Add logging to validatedWebRemoteType() r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/01ee611f9740
pt 6. Add some logging to shouldLoadUri r=mattwoodrow

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/83770ec96b2e
https://hg.mozilla.org/mozilla-central/rev/65357be13f82
https://hg.mozilla.org/mozilla-central/rev/4665050e46f0
https://hg.mozilla.org/mozilla-central/rev/d9ea56821b1a
https://hg.mozilla.org/mozilla-central/rev/7244027ef6ed
https://hg.mozilla.org/mozilla-central/rev/01ee611f9740