1618493 - [Wayland] PIP window can't be downsized with WebRender/GL compositor

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

PIP window can't be downsized with WebRender/GL compositor, there are gfx artifacts there.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Attachment: Bug 1618493 [Wayland] Set opaque region for accelerated window immediately, r?jhorak"

Recently opaque region is set when wl_surface is obtained by renderer/compositor.
It does not work as GL/WebRender get wl_surface only once and creates egl_window
on top of it so the opaque region is never updated.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31cf4e642b90
[Wayland] Set opaque region for accelerated window immediately, r=jhorak"

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/31cf4e642b90

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

Comment on attachment 9129485 [details]
Bug 1618493 [Wayland] Set opaque region for accelerated window immediately, r?jhorak"

Beta/Release Uplift Approval Request

• User impact if declined: Firefox window / PIP window can't be downsized when WebRender/GL compositor is used.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Wayland/Linux only.
• String changes made/needed: none

Comment 5

[Julien Cristau [:jcristau]]

webrender and gl compositor are both disabled by default, right?

Comment 6

[Martin Stránský [:stransky] (ni? me) (PTO till Feb 21)]

(In reply to Julien Cristau [:jcristau] from comment #5)

webrender and gl compositor are both disabled by default, right?

Yes, both disabled by default.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9129485 [details]
Bug 1618493 [Wayland] Set opaque region for accelerated window immediately, r?jhorak"

P3, we shipped out last beta and Wayland + gl compositor + webrender is too much of an edge case for an uplift before RC. I think this patch can ride the 75 train and benefit from more baking on pre-release channels.