1618506 - Perma TEST-UNEXPECTED-FAIL | /cookies/samesite/fetch.https.html | Cross-site fetches are cross-site - assert_not_equals: Unspecified-SameSite cookies are not sent with cross-site requests. got disallowed value when Gecko 75 merges to Beta on 2020-03-09

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central as beta:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=f3da5e550387745167928aa11e46d1adc58dc712&selectedJob=290740141
Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=290740141&repo=try&lineNumber=5225

[task 2020-02-27T11:06:21.305Z] 11:06:21 INFO - TEST-START | /cookies/samesite/fetch.https.html
[task 2020-02-27T11:06:21.309Z] 11:06:21 INFO - Closing window 27
[task 2020-02-27T11:06:21.406Z] 11:06:21 INFO - Closing window 10737418243
[task 2020-02-27T11:06:21.407Z] 11:06:21 INFO - PID 2027 | [Child 2033, Main Thread] WARNING: nsAppShell::Exit() called redundantly: file /builds/worker/workspace/build/src/widget/cocoa/nsAppShell.mm, line 725
[task 2020-02-27T11:06:21.436Z] 11:06:21 INFO - PID 2027 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-02-27T11:06:21.436Z] 11:06:21 INFO - PID 2027 | ###!!! [Parent][RunMessage] Error: Channel closing: too late to send/recv, messages will be lost
[task 2020-02-27T11:06:21.458Z] 11:06:21 INFO - PID 2027 | [Child 2034, Main Thread] WARNING: NS_ENSURE_TRUE(mPresShell) failed: file /builds/worker/workspace/build/src/layout/base/nsPresContext.cpp, line 848
[task 2020-02-27T11:06:21.636Z] 11:06:21 INFO - PID 2027 | [2035, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2020-02-27T11:06:21.637Z] 11:06:21 INFO - PID 2027 | [2035, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2020-02-27T11:06:21.637Z] 11:06:21 INFO - PID 2027 | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/pz/cx_1w9nx1dq_7zbylk7gbz30000017/T/tmpJ85ozi.mozrunner/runtests_leaks_1812_tab_pid2035.log
[task 2020-02-27T11:06:21.637Z] 11:06:21 INFO - PID 2027 | [2035, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2020-02-27T11:06:21.637Z] 11:06:21 INFO - PID 2027 | [2035, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 198
[task 2020-02-27T11:06:21.665Z] 11:06:21 INFO - PID 2027 | [Child 2033, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/workspace/build/src/xpcom/base/nsCycleCollector.cpp, line 3362
[task 2020-02-27T11:06:21.705Z] 11:06:21 INFO - PID 2027 | [Child 2035, Main Thread] WARNING: No CID found when attempting to map contract ID: file /builds/worker/workspace/build/src/xpcom/components/nsComponentManager.cpp, line 721
[task 2020-02-27T11:06:21.753Z] 11:06:21 INFO - PID 2027 | nsStringStats
[task 2020-02-27T11:06:21.755Z] 11:06:21 INFO - PID 2027 | => mAllocCount: 16063
[task 2020-02-27T11:06:21.755Z] 11:06:21 INFO - PID 2027 | => mReallocCount: 0
[task 2020-02-27T11:06:21.757Z] 11:06:21 INFO - PID 2027 | => mFreeCount: 16063
[task 2020-02-27T11:06:21.757Z] 11:06:21 INFO - PID 2027 | => mShareCount: 27082
[task 2020-02-27T11:06:21.757Z] 11:06:21 INFO - PID 2027 | => mAdoptCount: 502
[task 2020-02-27T11:06:21.758Z] 11:06:21 INFO - PID 2027 | => mAdoptFreeCount: 518
[task 2020-02-27T11:06:21.758Z] 11:06:21 INFO - PID 2027 | => Process ID: 2033, Thread ID: 4525671872
[task 2020-02-27T11:06:22.072Z] 11:06:22 INFO - PID 2027 | [Child 2034, Main Thread] WARNING: NS_ENSURE_TRUE(rootFrame) failed: file /builds/worker/workspace/build/src/dom/base/nsGlobalWindowOuter.cpp, line 4018
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO -
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO - TEST-PASS | /cookies/samesite/fetch.https.html | Same-host fetches are strictly same-site
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO - TEST-PASS | /cookies/samesite/fetch.https.html | Subdomain fetches are strictly same-site
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO - TEST-UNEXPECTED-FAIL | /cookies/samesite/fetch.https.html | Cross-site fetches are cross-site - assert_not_equals: Unspecified-SameSite cookies are not sent with cross-site requests. got disallowed value "0.1829412291433744"
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO - verifySameSiteCookieStateWithSameSiteByDefault@https://web-platform.test:8443/cookies/resources/cookie-helper.sub.js:181:24
[task 2020-02-27T11:06:26.582Z] 11:06:26 INFO - create_test/</</<@https://web-platform.test:8443/cookies/samesite/fetch.https.html:18:51

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1618506 - cookies/samesite WPTs require cookie sameSite=lax by default in release, r?ehsan

Comment 2

[Arthur Iakab [arthur_iakab]]

Importing the patch in today's beta sim seems to fix the failures: https://treeherder.mozilla.org/?#/jobs?repo=try&group_state=expanded&revision=844a805ed6ebf40bb80c448514386a0e82518e5d&searchStr=wpt

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d16161a6b742
cookies/samesite WPTs require cookie sameSite=lax by default in release, r=Ehsan

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d16161a6b742

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Verified fixed in today's beta simulation.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b2bdc9e0deb6b9f677f3b5f8668bdc63ac45a40&searchStr=OS%2CX%2C10.14%2Cdebug%2CWeb%2Cplatform%2Ctests%2Ctest-macosx1014-64%2Fdebug-web-platform-tests-e10s-10%2CW%28wpt10%29&selectedJob=291101808