Closed
Bug 1618541
Opened 5 years ago
Closed 5 years ago
Safeguard FileManager against uses after invalidation
Categories
(Core :: Storage: IndexedDB, task, P2)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla76
Tracking | Status | |
---|---|---|
firefox76 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta-
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D64401
Updated•5 years ago
|
Priority: -- → P2
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2989b564a4be
Add validity assertions to FileManager. r=dom-workers-and-storage-reviewers,janv
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9129500 [details]
Bug 1618541 - Add validity assertions to FileManager. r=#dom-workers-and-storage
Beta/Release Uplift Approval Request
- User impact if declined: Undefined behaviour may occur when IndexedDB operations are performed after invalidation of an origin depending on race conditions.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The behaviour of some methods is changed to return early with an error result. Without the changes, the behaviour would be undefined in these cases.
- String changes made/needed:
Attachment #9129500 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Is this is a new issue? Do we have evidence of issues in the wild caused by this? Or ways to test for it?
Flags: needinfo?(sgiesecke)
Comment 6•5 years ago
|
||
Comment on attachment 9129500 [details]
Bug 1618541 - Add validity assertions to FileManager. r=#dom-workers-and-storage
Simon provided context on slack, I think we can let this ride the trains.
Flags: needinfo?(sgiesecke)
Attachment #9129500 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in
before you can comment on or make changes to this bug.
Description
•