1618578 - All perfherder dropdowns have the items in alphabetical order

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Alexandru Irimovici]

We don't want the options order to be alphabetical for all the dropdowns.

Example of dropdown that should not be in alphabetical order: the time range dorpdown in graphs view
https://treeherder-prototype2.herokuapp.com/perf.html#/graphs

For better control we should define in DropdownMenuItems a component property named sortAlphabetically or something similar and have it default to false.

Comment 1

[Sarah Clements [:sclements]]

From what I remember of the pr review, the alphabetical sorting wasn't a requirement. Maybe just removing it makes the most sense? Any data that needs it in the future, especially if its only one thing, could be sorted before being passed to the DropdownMenuItems component.

Comment 2

[Alexandru Irimovici]

+1 I'm for removing the alphabetical order

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6090

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #1)

From what I remember of the pr review, the alphabetical sorting wasn't a requirement.

Forgot about the PR review discussions, but these requirements state that the unpinned items from the repository dropdown menu can be ordered alphabetically.

Maybe just removing it makes the most sense? Any data that needs it in the future, especially if its only one thing, could be sorted before being passed to the DropdownMenuItems component.

Yes, we could sort the items prior to passing them to the DropdownMenuItems component.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6152