1618606 - Remove FunctionBox::isInterpretedLazy() accessor

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

In Bug 1591600 we will eliminate the INTERPRETED_LAZY flag from functions. In order to do this, we should cleanup uses of it within frontend::FunctionBox.

This patch instead adds a FunctionBox::emitBytecode flag to indicate to the BCE whether the current function box should be emitted with bytecode or in lazy form.

Note that this definition is slightly different than the FunctionBox::isInterpretedLazy() was. In particular, placeholder function boxes for existing functions will not set the flag. It is only used when we expect the FunctionEmitter to actually generated bytecode.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1618606 - Remove FunctionBox::isInterpretedLazy() accessor. r?mgaudet

Avoid using the INTERPRETED_LAZY flag to control the BytecodeEmitter by
instead adding an emitBytecode flag to FunctionBox. This flag is set for
function boxes that we desire the BCE to emit code for. This paves the way to
remove the INTERPRETED_LAZY bit from functions themselves.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8687d8eff23b
Remove FunctionBox::isInterpretedLazy() accessor. r=mgaudet

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8687d8eff23b