Replace nsAutoPtr usage in parser/html with UniquePtr
Categories
(Core :: DOM: HTML Parser, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
Details
Attachments
(1 file)
This bug will track replacing usage of nsAutoPtr with UniquePtr in the parser/html directory. See bug 1610067, comment 0 for more details.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e65a9431a729 Remove nsAutoPtr usage from parser. r=hsivonen
|
||
Comment 3•4 years ago
|
||
Backed out changeset e65a9431a729 (bug 1618643) for build bustages in sHtml5TreeBuilderCppSupplement.h
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=291024022&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=e65a9431a729e41b7a09d91e2ba583962be88a85
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=291024022&repo=autoland&lineNumber=27396
Backout: https://hg.mozilla.org/integration/autoland/rev/cdd5b497014d049c1cdaeb9e66cb48fee6e30294
|
|
Assignee | |
Comment 4•4 years ago
|
||
Looks like we need a few more modifications to the generated code.
|
||
Comment 5•4 years ago
|
||
(In reply to Eric Rahm [:erahm] from comment #4)
Looks like we need a few more modifications to the generated code.
It looks like WrapUnique should not have been used in nsHtml5TreeBuilderCppSupplement.h since it's a non-owning pointer (the owner being in the tokenizer). (So not generated code.)
|
|
Assignee | |
Comment 6•4 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #5)
(In reply to Eric Rahm [:erahm] from comment #4)
Looks like we need a few more modifications to the generated code.
It looks like
WrapUniqueshould not have been used innsHtml5TreeBuilderCppSupplement.hsince it's a non-owning pointer (the owner being in the tokenizer). (So not generated code.)
Yep, noted that in phab as well.
Pushed by erahm@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7ac3680310d3 Remove nsAutoPtr usage from parser. r=hsivonen
|
||
Comment 8•4 years ago
|
||
| bugherder | ||
Description
•