1618763 - [GTK] Set GtkInputPurpose via inputmode attribute

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, enhancement, P3)

Description

[Makoto Kato [:m_kato]]

Actually, GtkInputPurpose is set by <input type=XXXX>. But we should reference inputmode attribute to set it.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1618763 - Part 1. mHTMLInputInputmode should be lower case except to mozAwesomebar.

Since we cannot use HTMLInputElement.GetInputMode since we still support
mozAwesomebar, inputmode attribute isn't sanitized. Since I would like to reduce
comparing cost, it should be lower case except to mozAwesomebar.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1618763 - Part 2. Use GtkInputPurpose and GtkInputHints by inputmode.

Let's use GtkInputPurpose and GtkInputHints by inputmode for software keyboard.

Depends on D67770

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Moving all open keyboard/IME handling bugs to DOM: UI Events & Focus Handling component.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac1ff4be2662
Part 1. mHTMLInputInputmode should be lower case except to mozAwesomebar. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0b9d1afee478
Part 2. Use GtkInputPurpose and GtkInputHints by inputmode. r=masayuki

Comment 5

[Dorel Luca [:dluca]]

Backed out 2 changesets (bug 1618763) for build bustage in checkouts/gecko/widget/gtk/IMContextWrapper.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294305983&repo=autoland&lineNumber=31908

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=0b9d1afee47825d630fa463660db11bd1e9250c3

Backout:
https://hg.mozilla.org/integration/autoland/rev/e1d0765b0da66f939155527ffa44c5e5dbd40c03

Comment 6

[Makoto Kato [:m_kato]]

Ah, I have to update widget/gtk/compat-gtk3/gtk/gtkenums.h

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32b70d050756
Part 1. mHTMLInputInputmode should be lower case except to mozAwesomebar. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/eef52683020b
Part 2. Use GtkInputPurpose and GtkInputHints by inputmode. r=masayuki

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/32b70d050756
https://hg.mozilla.org/mozilla-central/rev/eef52683020b