1618773 - Turn on dom.animations-api.implicit-keyframes.enabled and dom.animations-api.autoremove.enabled in release channels

Status: RESOLVED FIXED

(Core :: DOM: Animation, task, P3)

Description

[Brian Birtles (:birtles)]

We originally turned off implicit keyframes on release channels because we were afraid of users using them in patterns that lead to memory leaks.

We introduced the auto-remove behavior to counter potential memory leaks but didn't turn it on by default since we wanted to make sure Safari and Chrome were ok with that interface. They've both since implemented it without any changes to the spec so I think we're good to ship this.

Comment 1

[Brian Birtles (:birtles)]

I've sent an intent to ship for this but with dev-platform moderation what it is, it will possibly take a while to show up.

Comment 2

[Brian Birtles (:birtles)]

Attachment: Bug 1618773 - Turn on dom.animations-api.implicit-keyframes.enabled and dom.animations-api.autoremove.enabled unconditionally; r?boris

Comment 3

[Brian Birtles (:birtles)]

3 days later and my intent to ship still hasn't shown up on dev-platform 😓

Comment 4

[Brian Birtles (:birtles)]

Intent to ship: https://groups.google.com/forum/#!topic/mozilla.dev.platform/dhMQ7m2V7AY

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e42bf0b7e1af
Turn on dom.animations-api.implicit-keyframes.enabled and dom.animations-api.autoremove.enabled unconditionally; r=boris

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e42bf0b7e1af

Comment 7

[Chris Mills [:cmills]]

Documentation complete for this bug; see:

• https://github.com/mdn/sprints/issues/2933#issuecomment-604386088
• https://github.com/mdn/sprints/issues/2933#issuecomment-610839764

For details of what changes were made.