1618914 - MOZ_ENABLE_WAYLAND=1 crashes due to posix_fallocate failures

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Jan Beich]

Let's apply https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/54

Comment 1

[Jan Beich]

Attachment: v1

(Sorry, I can't submit on Phabricator due to bug 1536716.)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad06c4629a7eb449776b330714a4e9b72222ae7f

Comment 2

[Jan Beich]

Attachment: v2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8001a280e1c01e0983f74606edd5224b5025c9e9

Handle EINVAL and EOPNOTSUPP in WaylandShmPool::Resize as well.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Please use phabricator for it and mark me for review there.
Thanks.

Comment 4

[Jan Beich]

I can't as explained in bug 1536716.

Comment 5

[Jan Beich]

Attachment: v3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c73e14dba7bb859429b576947f7c150acd1d673

After bug 1619882 posix_fallocate is now called after shm_open (non-filesystem object) which is not supported by FreeBSD < 13. Let's ignore ENODEV as well.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247329#c3

Comment 6

[Jan Beich]

Attachment: v4

Rebased after bug 1711094.

Comment 7

[Robert Mader [:rmader]]

Attachment: Bug 1618914 - Fall back to ftruncate if posix_fallocate isn't supported by filesystem, r=stransky

Rebase of a patch by Jan Beich <[e-mail]>

Comment 8

[Robert Mader [:rmader]]

Thanks for the patch and sorry it took so long @Jan!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca4e0f9642ed
Fall back to ftruncate if posix_fallocate isn't supported by filesystem, r=stransky

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ca4e0f9642ed

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Do we need this on ESR?

Comment 12

[Robert Mader [:rmader]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #11)

Do we need this on ESR?

Nice to have - i.e. if it applies cleanly.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

It does. Feel free to nominate :)

Comment 14

[Robert Mader [:rmader]]

Comment on attachment 9253047 [details]
Bug 1618914 - Fall back to ftruncate if posix_fallocate isn't supported by filesystem, r=stransky

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fixes crashes in the (non-default) Wayland backend on some setups.
• User impact if declined: see above
• Fix Landed on Version: 96
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Code is simple and add a additional fallback for an unlikely case.
• String or UUID changes made by this patch:

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9253047 [details]
Bug 1618914 - Fall back to ftruncate if posix_fallocate isn't supported by filesystem, r=stransky

Approved for 91.5esr.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/cffffaa8d2ea