1618917 - Use default alias analysis GetObject semantics for some opcodes

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Description

[André Bargull [:anba]]

Some potential clean-ups noticed while working on bug 1614704.

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1618917 - Part 1: Use AliasSet::isNone() instead of testing isLoad() and isStore() separately. r=jandem!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1618917 - Part 2: Remove MArrayJoin::getAliasSet because it matches the default alias set. r=jandem!

Depends on D64776

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1618917 - Part 3: Fall through to the default case when getAliasSet() isn't overriden. r=jandem!

These three opcodes don't override getAliasSet(), so it's better to let the
default case handle them, because then we can assert the alias information is
correct in debug builds.

Depends on D64777

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1618917 - Part 4: Handle MCompare in the default case. r=jandem!

Similar to part 3, it seems better to get the debug check for MCompare for
free. Also this make MCompare more similar to other opcodes like MToString,
MBitNot, and MBinaryBitwiseInstruction, which all three either have a "none"
alias-set or the default "store-any" alias-set.

Depends on D64778

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40a351c7e4b1
Part 1: Use AliasSet::isNone() instead of testing isLoad() and isStore() separately. r=jandem
https://hg.mozilla.org/integration/autoland/rev/3d690e518780
Part 2: Remove MArrayJoin::getAliasSet because it matches the default alias set. r=jandem
https://hg.mozilla.org/integration/autoland/rev/f83f504514b6
Part 3: Fall through to the default case when getAliasSet() isn't overriden. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ce635c0f44ec
Part 4: Handle MCompare in the default case. r=jandem

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/40a351c7e4b1
https://hg.mozilla.org/mozilla-central/rev/3d690e518780
https://hg.mozilla.org/mozilla-central/rev/f83f504514b6
https://hg.mozilla.org/mozilla-central/rev/ce635c0f44ec