1618980 - ChannelWrapper returns incorrect requestSize and responseSize

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Gary Chen [:xeonchen]]

Bug 1545423 introduced ChannelWrapper.requestSize and ChannelWrapper.responseSize, but these values are cached and never refreshed. If the value had been read before nsHttpChannel::OnStopRequest, it will always be zero.

Comment 1

[Gary Chen [:xeonchen]]

Attachment: Bug 1618980 - clear RequestSize/ResponseSize cache;

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f55efd6af146
clear RequestSize/ResponseSize cache; r=mixedpuppy

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f55efd6af146

Comment 4

[Gary Chen [:xeonchen]]

Comment on attachment 9129861 [details]
Bug 1618980 - clear RequestSize/ResponseSize cache;

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1614777 may not able to collect bandwidth data on certain profiles.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only reset cached values on some specific criteria.
• String changes made/needed: N/A

Comment 5

[Pascal Chevrel:pascalc (PTO until Sept 2)]

Comment on attachment 9129861 [details]
Bug 1618980 - clear RequestSize/ResponseSize cache;

Patch is minimal and needed for the study in 74, uplift approved for the beta branch before RC.

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e341a0f9b594