Copy menu for WS message preview panels doesn't work
Categories
(DevTools :: Netmonitor, defect, P3)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: Harald, Assigned: Harald)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Both formatted JSON data and raw data do now allow copying data, the context menu just doesn't appear. This is especially odd in the raw data, as text can be selected but the context menu somehow prevented.
Other JSON views offer Copy/Copy All
.
The root cause is probably that other network panels use PropertiesView
, which provides onContextMenu: https://searchfox.org/mozilla-central/rev/a3266997560904b484fd89d6a6bcdeace4a13652/devtools/client/netmonitor/src/components/request-details/PropertiesView.js#136
WS's FramePayload.js
uses JSONPreview
directly which doesn't handle context menu on its own.
The raw section just uses a div
(https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/websockets/RawData.js#23), whereas the toolbox's copy context menu looks for textarea's to provide a native copy menu: https://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox.js#1145
Assignee | ||
Comment 1•5 years ago
|
||
Using the right components for WS inspection that support copy-context menus.
Updated•5 years ago
|
Pushed by hkirschner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a4603a12a92 Fix copy-contextmenu in WebSocket details panel r=bomsy
Comment 3•4 years ago
|
||
bugherder |
Description
•