1619145 - Add missing locale to app.update.url.* in firefox-branding.js

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement)

Description

[Suriyaa Sundararuban [:suriyaa]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Viewed the firefox-branding.js files in browser/branding/aurora/pref/firefox-branding.js and browser/branding/official/pref/firefox-branding.js.

Actual results:

Both prefs "app.update.url.manual" and "app.update.url.details" don't have a "%LOCALE%" in their URLs.

Expected results:

Adding missing "%LOCALE%" to these prefs. I'm working on this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Suriyaa Sundararuban [:suriyaa]]

Attachment: Bug 1619145 - Add locale to app.update.url.manual and app.update.url.details in firefox-branding.js.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:suriyaa, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Daniel Holbert [:dholbert]]

[Sorry for dropping in; just stumbled across this bug & noticed that it seems to have stalled]

:bytesized, do you know if this was intended to land?

See comment 3; looks like you reviewed this, and :suriyaa doesn't seem to have been active on bugzilla for a few months. so perhaps you could shepherd this in, if that'd be appropriate?)

Comment 5

[Robin Steuber (they/them) [:bytesized]]

As far as I know this was intended to land. Taking a look at the code, it looks like the patch is still needed. Unfortunately, it looks like a rebase is needed. I'm not really if I can (or should) to do that and retain :suriyaa's authorship of the patch. I guess I'll just take over the bug altogether.

Comment 6

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1619145 - Add locale to app.update.url.manual and app.update.url.details in firefox-branding.js r=mhowell

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e6c3477d8d
Add locale to app.update.url.manual and app.update.url.details in firefox-branding.js r=mhowell

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/00e6c3477d8d

Comment 9

[Daniel Holbert [:dholbert]]

Thanks for the reply & for taking care of this!

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #5)

I'm not really if I can (or should) to do that and retain :suriyaa's authorship of the patch.
I guess I'll just take over the bug altogether.

For future reference -- you can indeed retain (or add) someone else as the patch-author, when tweaking patches after-the-fact. (And typically in this sort of situation, where you're not making meaningful changes & you trust yourself not to screw anything up when editing the patch, it's a good idea to do that, so that the author "gets credit" in version control.)

You can set any arbitrary patch-author when committing by doing e.g. hg comm --user "[personA]" (or even [personA and personB] -- it's just a string), to override the default of using your own authorship info from your ~/.hgrc file. You also don't need to bother with this if you start out with a patch that you've imported (e.g. via moz-phab) which already has someone else as the author in the patch headers. You should be able to submit/resubmit the patch to phabricator regardless of who the recorded author is, and it'll preserve the author info that you specified.

(Not a big deal in this case, anyway, since the patch was relatively trivial. Thanks again for closing this out.)

Comment 10

[Robin Steuber (they/them) [:bytesized]]

Ah, thanks for letting me know! I'll do that in the future.

Comment 11

[Suriyaa Sundararuban [:suriyaa]]

@bytesized and @dholbert: Thank you for taking care of this patch.