1619163 - Missing icon for request header

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[u656278]

Attachment: Screenshot depicting the situation

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36

Steps to reproduce:

Send a regular HTTP request with the "Save-Data" header carrying value "on".

Actual results:

In the Dev Tools on the Network pane the question mark icon with the link pointing to related article on MDN does not appear before the line of the parameter.

Expected results:

An icon should appear for this parameter as well as it does for other parameters as well.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

I was able to reproduce the problem on my machine (using Edit and Resend feature we have)

1. Open DevTools and select the Network panel
2. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
3. Press the POST button on the page to generate request
4. Select the request and click the Edit And Resend button on the page
5. Add Save-Data request header in the list
6. Press Send to send the request
7. Select the new request (should happen automatically)
8. Check out the icon for Save-Data HTTP header - it's missing -> BUG

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some information for anyone interested in fixing this bug:

1. The icon is rendered here:
   https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/netmonitor/src/components/HeadersPanel.js#437-441

It's only rendered when we have URL to MDN set in headerDocURL

2. The list of supported HTTP headers is here:
   https://searchfox.org/mozilla-central/rev/d69ec052bed8700af7a283e37b60b4af22734930/devtools/client/netmonitor/src/utils/mdn-utils.js#15

3. MDN Page for Save-Data is here
   https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Save-Data

So, all we need to do is to put the hader name Save-Data into the list

Honza

Comment 4

[Mariana Pícolo]

Hello Honza,
I'd like to work on this one!

Thanks!

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Assigned to you, thanks for helping with this one.

Honza

Comment 6

[Mariana Pícolo]

Attachment: Bug 1619163 - Add "Save-Data" HTTP header. r=Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18c5f3e1f694
Add "Save-Data" HTTP header. r=Honza

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/18c5f3e1f694