Closed
Bug 1619191
Opened 5 years ago
Closed 5 years ago
Remove unnecessary console.error() calls
Categories
(Testing :: Raptor, defect, P3)
Tracking
(firefox74 unaffected, firefox75 fixed)
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox74 | --- | unaffected |
firefox75 | --- | fixed |
People
(Reporter: whimboo, Unassigned)
References
(Regression)
Details
With bug 1617909 I added a couple of console.error()
calls which seem to add noise to the Treeherder logs:
[task 2020-02-29T11:43:18.852Z] 11:43:18 ERROR - PID 3368 | console.error: "exception thrown: TypeError: text.split is not a function,processText@http://127.0.0.1:39824/unity-webgl/Data/mozbench.js:11:19\nModule.print@http://127.0.0.1:39824/unity-webgl/index.html?raptor:60:24\nabort@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:98:69204\nTKn@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:89:1\nuRb@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:41:1\ntRb@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:41:1\nzjc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:21:1\nGjc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:21:1\nYRc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:9:1\nRRc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:9:1\nunc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:21:1\nLRc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:9:1\njgc@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:21:1\nbdd@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:33:1\nx8f@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:45:1\nfGn@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:89:1\ndynCall@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:1:4741\nBrowser_mainLoop_runner/<@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:1:243649\nrunIter@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:1:132109\nBrowser_mainLoop_runner@http://127.0.0.1:39824/unity-webgl/Data/WebGLBenchmarks.js:1:243554\n"
[task 2020-02-29T11:43:18.888Z] 11:43:18 ERROR - PID 3368 | TypeError: text.split is not a functionconsole.info: "[raptor-runnerjs] checking results..."
Given that we We correctly print TypeError
we can avoid logging the error message. Also note that there is no new line before the console.log
call for checking results
.
Reporter | ||
Comment 1•5 years ago
|
||
I don't see that anymore for failing ugl
tests.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•