1619207 - Selecting "geckoview-junit" doesn't seem to work in try chooser

Status: NEW

(Developer Infrastructure :: Try, defect)

Description

[Marcos Caceres [:marcosc]]

When I run:

./mach try chooser

And I manually select "geckoview-junit", the tests don't actually seem to get converted to tasks... or maybe I'm missing something:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd3441af808da1344fcde251ebefa5a1dc41b89d

I can see it builds, but then doesn't seem to run the actual tests.

Here are the resulting tasks:
https://hg.mozilla.org/try/rev/fd3441af808da1344fcde251ebefa5a1dc41b89d

Maybe duplicate of bug 1617632

Comment 1

[Tom Prince [:tomprince]]

I'm not familiar with the details of of how try-chooser works, but it looks like the platform for the geckoview-junit tests does not match with any of the platforms on the platform page. If I just select geckoview-junit on the test-suites page, and no tests, then I get

test-android-em-7.0-x86_64/debug-geckoview-junit-e10s
test-android-em-7.0-x86_64/opt-geckoview-junit-e10s

as the set of tasks to run. But if I select any platform, then those tests are no longer selected. This is the expected behavior (at least for other test suites), since the tests have different platforms than those selected. That said, I think this should be handled better, but I don't know enough about try chooser to suggest any particualar solutions.

Comment 2

[Marcos Caceres [:marcosc]]

We should see if we can fix this somehow... like selecting "geckoview-junit" always runs irrespective of platform (similar to linting).

My own story is that I've been backed out twice after trying to merge because I'd assumed that my tests were passing (after doing a try chooser), only to find that these tests were actually failing and resulting a tree closure :( For other reasons, it's not been possible to reliably test "geckoview-junit" locally, so I'm completely reliant on Try to run these tests for me.

Comment 3

[Marcos Caceres [:marcosc]]

For anyone landing here in the future, if you are doing "try chooser" click on all the Android versions until you see one that causes all the tests... you should see like 50+ tasks suddenly appear. One of them will work.