Closed Bug 1619214 Opened 5 years ago Closed 5 years ago

Use parentFront property in Pool.js

Categories

(DevTools :: Framework, task, P3)

task

Tracking

(firefox76 fixed)

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(1 file)

In Pool, there are 2 places where we use poolFor in order to retrieve the parent. Depending of the number of pools and their sizes, this could be quite costly.

In many fronts, there's a parentFront property that maintain the link between a front and its parent.

The idea would be to use this if it exists, and fail back to poolFor only when needed, as it could be much more efficient.

In many fronts, there's a parentFront property that maintain the link between
a front and its parent, but Pool isn't using it, and retrieve the parent
through poolFor, which can be a bit slow depending the number of pools and
their size.
Trying to access the parent through parentFront if possible should be more
efficient.

Priority: -- → P3
Depends on: 1620270
Attachment #9130085 - Attachment description: Bug 1619214 - Use parentFront to retrieve parent pool when possible. r=ochameau. → Bug 1619214 - Use parentFront/parentActor to retrieve parent when possible. r=ochameau.
Attachment #9130085 - Attachment description: Bug 1619214 - Use parentFront/parentActor to retrieve parent when possible. r=ochameau. → Bug 1619214 - Use parentFront to retrieve parent when possible. r=ochameau.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/517dd2eac7dd Use parentFront to retrieve parent when possible. r=ochameau.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: