Closed Bug 1619340 Opened 6 years ago Closed 6 years ago

Explicitly disable individual gtests that fail on Android, instead of entire files

Categories

(Core :: Panning and Zooming, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Spinoff from https://bugzilla.mozilla.org/show_bug.cgi?id=1545234#c14. This just ifdef's out individual failing tests instead of skipping the entire file on Android. Subsequent bugs/patches can fix and re-enable the individual tests.

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=187b989dcb48ac4bbe97ab9217f4d32d76e591ed is better. Some more tests are failing (with a crash on debug builds) than were some months ago when I last tried this. So landing earlier could have caught some regressions :(

Instead of skipping entire files, ifdef out the individual tests that are
failing. This allows us to audit them one at a time to re-enable, while
prevent regressions in tests in those files that are already passing.

Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/53e21d1350a5 ifdef out the individual gtests failing on Android. r=botond
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: