Closed Bug 1619354 Opened 4 years ago Closed 4 years ago

Fix popup notification in modern theme

Categories

(SeaMonkey :: Passwords & Permissions, defect)

defect
Not set
normal

Tracking

(seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey 2.72
Tracking Status
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.2)

Attachments

(3 files)

Attached image Password-ui.png

The popup notification / door hanger for logins / passwords in the modern theme has regressed. The dropdown for Never Save has become a separate button, needs some css magic to fix it.

Attached image Password-ui-v1.png

With dropdown button adjusted

[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: middle drop down with no text
Testing completed (on m-c, etc.): 2.53.2 on linux
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

This will need testing on Windows and macOS too.

Attachment #9130462 - Flags: review?(frgrahl)
Attachment #9130462 - Flags: approval-comm-release?
Attachment #9130462 - Flags: approval-comm-esr60?
Comment on attachment 9130462 [details] [diff] [review]
Fix popup in modern theme

Great. Not pretty but works. Can be enhanced later.
Attachment #9130462 - Flags: review?(frgrahl)
Attachment #9130462 - Flags: review+
Attachment #9130462 - Flags: approval-comm-release?
Attachment #9130462 - Flags: approval-comm-release+
Attachment #9130462 - Flags: approval-comm-esr60?
Attachment #9130462 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b2cecde80ad8
Fix popup notification in modern theme. r=frg DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.72
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: