Closed Bug 1619445 Opened 11 months ago Closed 11 months ago

Fix ImmutableScriptFlags

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: caroline, Assigned: caroline)

References

Details

Attachments

(2 files)

  • Move IsDefaultClassConstructor to MutableFlags, because it is only set once parse is done and after self-hosted.js is run.
  • Split Strict into two flags, one ForceStrict as an input flag and one Strict as a parse flag.
  • Split TreatAsRunOnce into multiple (potentially 3 flags) for the Parser and BCE.
Assignee: nobody → ccullen
Blocks: 1619011
Priority: -- → P2

:caroline , patches failed to land :
"Revisions: D65274 diff 243092 ← D65275 diff 243093

            Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

applying /tmp/tmpLHf1Vv
js/src/vm/JSFunction.cpp
Hunk #1 FAILED at 1752.
1 out of 1 hunk FAILED -- saving rejects to file js/src/vm/JSFunction.cpp.rej
abort: patch command failed: exited with status 256"

Flags: needinfo?(ccullen)

Manually rebased now.

Flags: needinfo?(ccullen)

Caroline, getting the same error:

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

applying /tmp/tmpLVGXMD
js/src/frontend/Stencil.h
Hunk #1 FAILED at 67.
Hunk #2 FAILED at 74.
2 out of 2 hunks FAILED -- saving rejects to file js/src/frontend/Stencil.h.rej
js/src/frontend/Parser.cpp
Hunk #1 FAILED at 1677.
1 out of 2 hunks FAILED -- saving rejects to file js/src/frontend/Parser.cpp.rej
abort: patch command failed: exited with status 256
Flags: needinfo?(ccullen)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1a37a40dc640
Remove isDefaultClassConstructor immutable flag. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/651f6b4c7d74
Split strict flag into two distinct flags for input and parse. r=tcampbell
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Flags: needinfo?(ccullen)
You need to log in before you can comment on or make changes to this bug.