1619455 - Kill GC/CC timers on content-child-will-shutdown

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task)

Description

[Andrew McCreight [:mccr8]]

When content-child-will-shutdown gets signalled, we've begun to shut down the content process. We should kill the GC timers when this happens to avoid shutdown hangs in child processes. I don't know how much it will help in practice.

Basically this just requires tweaking nsJSEnvironmentObserver to listen for content-child-will-shutdown and add that topic to the section of Observer() that handles quit-application. Then test it and hope it doesn't cause other issues.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1619455 - Kill GC/CC timers on content-child-will-shutdown.

Hopefully this will reduce the number of shutdown hangs in child processes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c56290d76bef
Kill GC/CC timers on content-child-will-shutdown. r=smaug

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c56290d76bef

Comment 4

[Andrew McCreight [:mccr8]]

It looks like maybe this has reduced the number of shutdown hangs where a GC is ongoing. Also, I looked at some GC shutdown hangs before and after this landed, and I saw some with an IPC shutdown state before, but not after.