1619478 - RDM doesn’t close between process switches

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Micah [:mtigley] (she/her)]

STR

1. Make sure devtools.target-switching.enabled is false.
2. Open RDM and go to https://wiki.mozilla.org/Main_Page
3. Navigate to about:robots

Expected
RDM should close due to a remoteness change from content -> parent processes.

Actual
RDM is still open. However, if you try closing RDM nothing will happen.

There's a race between the navigation from the content -> parent process and closing RDM as needed. So we need to make sure we're closing RDM before the navigation happens.

Comment 1

[Micah [:mtigley] (she/her)]

Attachment: Bug 1619478 - Ensure that actor methods are not being called before a remoteness change

Target switching support involves actors being destroyed during process flips. However, when RDM is closed due to a remoteness change, we are still trying to call methods on an actor that has already been destroyed. We need to ensure this doesn't happen by only calling these methods in destroy if RDM is being closed manually by the user.

Comment 2

[Micah [:mtigley] (she/her)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c3546310ff3e29849854a9dfb26e1cf2c9a22b7

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7734215faecf
Ensure that actor methods are not being called before a remoteness change r=bradwerth

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7734215faecf