1619544 - Crash in [@ arena_dalloc | replace_free | mozilla::FFmpegVideoDecoder<T>::InitVAAPIDecoder]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P5)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-cb59f9f2-e0cf-470d-a7de-d0b6f0200303.

Top 10 frames of crashing thread:

0 firefox-bin arena_dalloc memory/build/mozjemalloc.cpp:3363
1 firefox-bin replace_free memory/replace/phc/PHC.cpp:1155
2 libxul.so mozilla::FFmpegVideoDecoder<58>::InitVAAPIDecoder dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:202
3 libxul.so mozilla::FFmpegVideoDecoder<58>::Init dom/media/platforms/ffmpeg/FFmpegVideoDecoder.cpp:284
4 libxul.so mozilla::detail::ProxyFunctionRunnable<mozilla::MediaChangeMonitor::Init xpcom/threads/MozPromise.h:1456
5 libxul.so mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:207
6 libxul.so nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:299
7 libxul.so non-virtual thunk to nsThreadPool::Run xpcom/threads/nsThreadPool.cpp
8 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
9 libxul.so <name omitted> xpcom/threads/nsThreadUtils.cpp:481

There are 3 crashes (from 2 installations) in nightly 75 with buildid 20200302212732. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1616185.

[1] https://hg.mozilla.org/mozilla-central/rev?node=da012bb39f2b

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1619544 [Wayland] Do locking in VA-API codec creation, r?jya

We need to lock codec creation as ffmpeg/libva does not provide any kind of synchronization here.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a599c79ed651
[Wayland] Do locking in VA-API codec creation, r=jya

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a599c79ed651