Closed Bug 1619573 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22062 - [css-grid] Fix referencing implicit grid line after auto repeat()

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22062 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22062
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Fix referencing implicit grid line after auto repeat()

The indices of both implicit grid lines defined with grid-template-areas
and explicit ones defined with grid-template-rows/columns used to be
stored together in NamedGridColumnLines and NamedGridRowLines.

However, this was problematic, because the former indices already refer
to the final explicit grid so they don't have to be increased when
expanding an auto repeat(), but the latter ones should.

Therefore, this patch stores the indices in separate fields and uses the
correct logic for each one.

BUG=966090

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-005.html
TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-006.html

Change-Id: I6d423148af0e4dd865f130742f7a927a325cef90
Reviewed-on: https://chromium-review.googlesource.com/2081823
WPT-Export-Revision: 72b15107332b59e485cb11306a487e2b512fb03e

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 2

Chrome

PASS: 1
FAIL: 1

Safari

PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b21c3931e54
[wpt PR 22062] - [css-grid] Fix referencing implicit grid line after auto repeat(), a=testonly

https://hg.mozilla.org/mozilla-central/rev/4b21c3931e54

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.