1619592 - Get rid of QuotaManager::EnsureStorageAndOriginIsInitialized

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This method currently ensures that storage, temporary storage and the origin is initialized. However, for example LSNG needs more fine grained work flow and when there's no localStorage data for given origin it just makes sure storage and temporary storage is initialized. The origin is initialized later when we actually need to flush data to disk.
Also, by forcing quota clients to call individual methods, it will be slightly more visible when one of these methods fail and also what is actually happening/what needs to be initialized.

Comment 1

[Jan Varga [:janv]]

This is also needed for converting test_unknownFiles.js to the new declarative testing infrastructure.

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Update selected operations to not implicitly initialize storage; r=#dom-workers-and-storage-reviewers

All initialization related operations, the clear all operation and reset
operations now fail if storage is not initialized.
All other operations make sure storage is initialized by setting the
mNeedsStorageInit flag. DirectoryWork() for these operations now assert that
storage is initialized.
The aResetAll param has been removed from resetStoragesForPrincipal since
there's no use case for it right now (if there's a use case for it in future,
it should be handled by a separate method like clearOriginsByPrefix).
This patch also separates ResetOriginOp from ClearOriginOp for better
readibility of code.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Remove unused EnsureStorageAndOriginIsInitialized method; r=#dom-workers-and-storage-reviewers

EnsureStorageAndOriginIsInitialized has been replaced with:
EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized.
Both methods require initialized storage via EnsureStorageIsInitialized.
EnsureTemporaryOriginIsInitialized additionally requries initialized temporary
storage via EnsureTemporaryStorageIsInitialized.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50af9d58c645
Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg

Comment 7

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 50af9d58c645 (Bug 1619592) for causing build bustages in /builds/worker/checkouts/gecko/dom/quota/PersistenceType.cpp CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=292638058

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292638058&repo=autoland&lineNumber=9358

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24cc377eedd8
Backed out changeset 50af9d58c645 for causing build bustages in /builds/worker/checkouts/gecko/dom/quota/PersistenceType.cpp CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6567a3000e96
Rationalize PersistenceTypeTo* and PersistenceTypeFrom* methods; r=dom-workers-and-storage-reviewers,sg

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6567a3000e96

Comment 11

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Refactor persistence type checks using new IsValidPersistenceType method; r=#dom-workers-and-storage-reviewers

Comment 12

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Refactor client type checks using new Client::IsValidType method; r=#dom-workers-and-storage-reviewers

Comment 13

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Separate ResetOriginOp from ClearOriginOp; r=#dom-workers-and-storage-reviewers

ResetOriginOp has been separated from ClearOriginOp for better readibility of
code.

Comment 14

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Remove aResetAll param from nsIQuotaManagerService::ResetStoragesForPrincipal; r=#dom-workers-and-storage-reviewers

The aResetAll param has been removed from resetStoragesForPrincipal since
there's no use case for it right now (if there's a use case for it in future, it
should be handled by a separate method like resetOriginsByPrefix).

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d749e4d81c35
Refactor persistence type checks using new IsValidPersistenceType method; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/c5b818f1397c
Refactor client type checks using new Client::IsValidType method; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/c6f81e43e149
Separate ResetOriginOp from ClearOriginOp; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/31ada6206090
Remove aResetAll param from nsIQuotaManagerService::ResetStoragesForPrincipal; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/afa84f8037a5
Update selected operations to not implicitly initialize storage; r=dom-workers-and-storage-reviewers,sg

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d749e4d81c35
https://hg.mozilla.org/mozilla-central/rev/c5b818f1397c
https://hg.mozilla.org/mozilla-central/rev/c6f81e43e149
https://hg.mozilla.org/mozilla-central/rev/31ada6206090
https://hg.mozilla.org/mozilla-central/rev/afa84f8037a5

Comment 17

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Remove unused aClientType argument in EnsureStorageAndOriginIsInitialized; r=#dom-workers-and-storage-reviewers

Comment 18

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Convert EnsureDirectory, EnsureOriginDirectory, EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized to use mozilla::Result and QM_TRY; r=#dom-workers-and-storage-reviewers

Depends on D97253

Comment 19

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Add initializePersistentOrigin and initializeTemporaryOrigin to nsIQuotaManagerService; r=#dom-workers-and-storage-reviewers

Depends on D97254

Comment 20

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/quota; r=#dom-workers-and-storage-reviewers

Depends on D97255

Comment 21

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/indexedDB; r=#dom-workers-and-storage-reviewers

Depends on D97256

Comment 22

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Replace EnsureStorageAndOriginIsInitialized with EnsureTemporaryOriginIsInitialized in dom/cache; r=#dom-workers-and-storage-reviewers

Depends on D97257

Comment 23

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/simpledb; r=#dom-workers-and-storage-reviewers

Depends on D97258

Comment 24

[Jan Varga [:janv]]

Attachment: Bug 1619592 - Replace EnsureStorageAndOriginIsInitialized with EnsureTemporaryOriginIsInitialized in dom/localstorage; r=#dom-workers-and-storage-reviewers

Depends on D97259

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c33d91bff7d
Remove unused aClientType argument in EnsureStorageAndOriginIsInitialized; r=dom-workers-and-storage-reviewers,sg

Comment 26

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4c33d91bff7d

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e8572b4f56f
Convert EnsureDirectory, EnsureOriginDirectory, EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized to use mozilla::Result and QM_TRY; r=dom-workers-and-storage-reviewers,sg

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8db250609526
Add initializePersistentOrigin and initializeTemporaryOrigin to nsIQuotaManagerService; r=dom-workers-and-storage-reviewers,sg

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4e713da4380
Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/quota; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/e16ce60b0942
Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/indexedDB; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/61d0d2245183
Replace EnsureStorageAndOriginIsInitialized with EnsureTemporaryOriginIsInitialized in dom/cache; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/056fd84bddfb
Replace EnsureStorageAndOriginIsInitialized with EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized in dom/simpledb; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/a515433c3eb8
Replace EnsureStorageAndOriginIsInitialized with EnsureTemporaryOriginIsInitialized in dom/localstorage; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/01623709adc4
Remove unused EnsureStorageAndOriginIsInitialized method; r=dom-workers-and-storage-reviewers,sg

Comment 30

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9e8572b4f56f

Comment 31

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8db250609526
https://hg.mozilla.org/mozilla-central/rev/d4e713da4380
https://hg.mozilla.org/mozilla-central/rev/e16ce60b0942
https://hg.mozilla.org/mozilla-central/rev/61d0d2245183
https://hg.mozilla.org/mozilla-central/rev/056fd84bddfb
https://hg.mozilla.org/mozilla-central/rev/a515433c3eb8
https://hg.mozilla.org/mozilla-central/rev/01623709adc4