Get rid of QuotaManager::EnsureStorageAndOriginIsInitialized
Categories
(Core :: Storage: Quota Manager, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox85 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 2 open bugs)
Details
Attachments
(15 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
This method currently ensures that storage, temporary storage and the origin is initialized. However, for example LSNG needs more fine grained work flow and when there's no localStorage data for given origin it just makes sure storage and temporary storage is initialized. The origin is initialized later when we actually need to flush data to disk.
Also, by forcing quota clients to call individual methods, it will be slightly more visible when one of these methods fail and also what is actually happening/what needs to be initialized.
Assignee | ||
Comment 1•5 years ago
|
||
This is also needed for converting test_unknownFiles.js to the new declarative testing infrastructure.
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
All initialization related operations, the clear all operation and reset
operations now fail if storage is not initialized.
All other operations make sure storage is initialized by setting the
mNeedsStorageInit flag. DirectoryWork() for these operations now assert that
storage is initialized.
The aResetAll param has been removed from resetStoragesForPrincipal since
there's no use case for it right now (if there's a use case for it in future,
it should be handled by a separate method like clearOriginsByPrefix).
This patch also separates ResetOriginOp from ClearOriginOp for better
readibility of code.
Assignee | ||
Comment 4•5 years ago
|
||
EnsureStorageAndOriginIsInitialized has been replaced with:
EnsurePersistentOriginIsInitialized and EnsureTemporaryOriginIsInitialized.
Both methods require initialized storage via EnsureStorageIsInitialized.
EnsureTemporaryOriginIsInitialized additionally requries initialized temporary
storage via EnsureTemporaryStorageIsInitialized.
Assignee | ||
Comment 5•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Backed out changeset 50af9d58c645 (Bug 1619592) for causing build bustages in /builds/worker/checkouts/gecko/dom/quota/PersistenceType.cpp CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=292638058&repo=autoland&lineNumber=9358
Comment 10•5 years ago
|
||
bugherder |
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
ResetOriginOp has been separated from ClearOriginOp for better readibility of
code.
Assignee | ||
Comment 14•5 years ago
|
||
The aResetAll param has been removed from resetStoragesForPrincipal since
there's no use case for it right now (if there's a use case for it in future, it
should be handled by a separate method like resetOriginsByPrefix).
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•4 years ago
|
Assignee | ||
Comment 17•4 years ago
|
||
Assignee | ||
Comment 18•4 years ago
|
||
Depends on D97253
Assignee | ||
Comment 19•4 years ago
|
||
Depends on D97254
Assignee | ||
Comment 20•4 years ago
|
||
Depends on D97255
Assignee | ||
Comment 21•4 years ago
|
||
Depends on D97256
Assignee | ||
Comment 22•4 years ago
|
||
Depends on D97257
Assignee | ||
Comment 23•4 years ago
|
||
Depends on D97258
Assignee | ||
Comment 24•4 years ago
|
||
Depends on D97259
Updated•4 years ago
|
Comment 25•4 years ago
|
||
Comment 26•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Comment 27•4 years ago
|
||
Updated•4 years ago
|
Comment 28•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Comment 29•4 years ago
|
||
Comment 30•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Comment 31•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8db250609526
https://hg.mozilla.org/mozilla-central/rev/d4e713da4380
https://hg.mozilla.org/mozilla-central/rev/e16ce60b0942
https://hg.mozilla.org/mozilla-central/rev/61d0d2245183
https://hg.mozilla.org/mozilla-central/rev/056fd84bddfb
https://hg.mozilla.org/mozilla-central/rev/a515433c3eb8
https://hg.mozilla.org/mozilla-central/rev/01623709adc4
Description
•