1619602 - Recompute ContentBlockingAllowListPrincipal if it is a top-level load

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Dimi Lee [:dimi]]

See Bug 1612378 Comment 6 for details.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1619602 - Part 1: Recompute the ContentBlockingAllowListPrincipal if this is a top-level load. r?dimi,Ehsan

For top-level load, we only recompute the ContentBlockingAllowListPrincipal
if the original one is a NullPrincipal. This is for the case for the
initial navigation from about:blank to the loading page. But if we do a
navigation that it is not from the about:blank, we won't recompute it.
This introduces an issue that we would use a wrong principal for the
top-level loading channel.

This patch enforces the recomputation for the top-level loading
regardlesss if the original ContentBlockingAllowList is a NullPrincipal.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1619602 - Part 2: Don't overwrite the existing ContentBlockingAllowListPrincipal when doing a recomputation in the Document. r?dimi,Ehsan

It is incorrect to overwrite the existing
ContentBlockingAllowListPrincipal when doing a recomputaion in the
Document. The ContentBlockingAllowListPrincipal in the document should
be updated in Document::SetPrincipals().

Depends on D65404

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98035072dea9
Part 1: Recompute the ContentBlockingAllowListPrincipal if this is a top-level load. r=dimi,Ehsan
https://hg.mozilla.org/integration/autoland/rev/396f55ee4672
Part 2: Don't overwrite the existing ContentBlockingAllowListPrincipal when doing a recomputation in the Document. r=dimi,Ehsan

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/98035072dea9
https://hg.mozilla.org/mozilla-central/rev/396f55ee4672