1619605 - Fix WebAssembly baseline codegen for multi-value calls

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect)

Description

[Andy Wingo [:wingo]]

Now that both Ion and baseline support multi-value calls, I am finally testing it :) This bug will have a patch that fixes baseline codegen issues.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Bug 1619605 - Fix wasm baseline multi-value codegen

This patch fixes a few WebAssembly codegen issues in the multi-value
call support, in the baseline compiler.

• The local variable iterator was incorrectly calculating the range of
  the non-arg locals, and thereby zeroing out the stored stack results
  pointer.

• Initializing locals from arguments on function entry was erroneously
  treating the synthetic stack results pointer argument as a local.

• A bug prevented popStackResultsToMemory from actually popping the
  stack.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/763a5d614242
Fix wasm baseline multi-value codegen r=lth

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/763a5d614242