1619606 - Add CheckedUnsafePtr to the prefix list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Simon Giesecke [:sg] [he/him]]

CheckedUnsafePtr assertions show up with a very generic signature, as can be seen in https://crash-stats.mozilla.org/report/index/709d791b-1f4f-4b2e-8cff-235380200302, e.g.
The first two frames should be added to the prefix list:

mozilla::CheckCheckedUnsafePtrs<mozilla::CrashOnDanglingCheckedUnsafePtr>::Check(nsTArray<mozilla::detail::CheckedUnsafePtrBase<(mozilla::CheckingSupport)0>*>&)
mozilla::detail::SupportCheckedUnsafePtrImpl<mozilla::CrashOnDanglingCheckedUnsafePtr, (mozilla::CheckingSupport)0>::~SupportCheckedUnsafePtrImpl()

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P2 to do soon.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Simon: Does this look right?

app@socorro:/app$ socorro-cmd signature  https://crash-stats.mozilla.org/report/index/709d791b-1f4f-4b2e-8cff-235380200302
Crash id: 709d791b-1f4f-4b2e-8cff-235380200302
Original: mozilla::CheckCheckedUnsafePtrs<T>::Check
New:      mozilla::CheckCheckedUnsafePtrs<T>::Check | mozilla::detail::SupportCheckedUnsafePtrImpl<T>::~SupportCheckedUnsafePtrImpl | mozilla::dom::indexedDB::(anonymous namespace)::FactoryOp::~FactoryOp
Same?:    False

Comment 3

[Simon Giesecke [:sg] [he/him]]

Yes, that looks good!

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 5264: bug 1619606: add mozilla::CheckCheckedUnsafePtrs<T>::Check to prefix list

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #5264: "bug 1619606: add mozilla::CheckCheckedUnsafePtrs<T>::Check to prefix list" in 93cc456.

Comment 6

[Simon Giesecke [:sg] [he/him]]

Was this already deployed? https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3ACheckCheckedUnsafePtrs%3CT%3E%3A%3ACheck&date=%3E%3D2020-03-03T09%3A28%3A00.000Z&date=%3C2020-03-10T09%3A28%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1 still shows two crashes on 2020-03-07 and 2020-03-09 where this is not handled as a prefix.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

This hasn't been deployed to production, yet.

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this to production just now. Marking as FIXED.